Skip to content

feat(reports): leftover-map item coordinates on leftover-map graphic leftover-map criterion markers independently of leftover-map post ξ markers (v2.92.0) - #876

Draft
seonghobae wants to merge 33 commits into
feat/leftover-map-axis-tick-share-badge-v2910from
feat/leftover-map-plot-criterion-coordinates-v2920
Draft

seonghobae wants to merge 33 commits into
feat/leftover-map-axis-tick-share-badge-v2910from
feat/leftover-map-plot-criterion-coordinates-v2920

Conversation

@seonghobae

@seonghobae seonghobae commented Aug 31, 2026 •

Copy link
Copy Markdown
Contributor

Current exact authority — 2026-09-21

Ordinary/non-force convergence semantically merged the criterion-coordinate delta onto repaired responsive/numeric-tick ancestry: dynamic layout sizing, bounded captions, numeric coordinate identity, right-bounded axis-2 caption and exact σ+share owner evidence remain intact. No predecessor receipt transfers.

…leftover-map criterion markers independently of leftover-map post ξ markers (v2.92.0)

Caption leftover-map graphic leftover-map criterion markers with persisted leftover-map item coordinates through leftoverMapPlotCriterionBadge independently of leftover-map post ξ markers (ADR 0335). Rank-0 unused axes still name leftover-map item coordinates (0.00, 0.00). A missing or non-finite leftover-map item coordinate pair omits independently of leftover-map post ξ. Do not invent leftover-map item coordinates from leftover-map post ξ. UI-only; no SQL; never invent a leftover score or a theta.
@coderabbitai

coderabbitai Bot commented Aug 31, 2026 •

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copy link
Copy Markdown
Contributor Author

Leave #876 open for independent APPROVE on exact head 89ed56b. Do not squash-merge. Do not self-approve. Copilot/Devin COMMENT is not independent APPROVE. Stacked onto leftover-axis tick leftover-map axis share (feat/leftover-map-axis-tick-share-badge-v2910 / #875 @ d19f1fd). After independent review, retarget leftover-map stack onto leftover-coordinates (feat/leftover-map-coordinates-v2240 / #782, already merged to main) rather than squash-merging here. Issues #79 and #87 stay open. Do not merge #808 without independent APPROVE. Leftover-map comparison graphic leftover-map criterion markers stay Criterion ζ {label} this increment.

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 2 potential issues.

Devin Review

Comment thread frontend/src/leftoverMapPlotLayout.ts
Comment thread frontend/src/components/LeftoverMapPlot.tsx Outdated
Adopt exact reconstructed #875 as the repaired tree while preserving historical #876 as first parent. Retain v2.92 criterion-marker intent as one executable RED: report graphic criterion markers must name persisted ζ item coordinates through the canonical coordinate formatter, fail closed on incomplete/non-finite pairs, preserve zero, and never infer item coordinates from post ξ. No force update or stale source replay.
chore(stack): converge #876 onto repaired #875 head
Ordinary non-force ancestry adoption. Preserve #876 report-graphic criterion item-coordinate contract delta while inheriting repaired comparison-distance assertions.
seonghobae added a commit that referenced this pull request Sep 13, 2026
Ordinary non-force ancestry adoption. Preserve #1033 reconstructed comparison criterion-coordinate contract and historical #878 product ancestry.

Copy link
Copy Markdown
Contributor Author

Current ancestry authority: exact head is now 259e2d1ad8545bda75873a15c9e1b0de13996e4f, adopting repaired #875/#859 ancestry by ordinary non-force merge while preserving the report-graphic criterion item-coordinate contract. The former inherited #859 stale-assertion RED is repaired in ancestry; this does not transfer GREEN evidence. Reconstructed successor #1033 has also been converged onto this exact parent. Historical #878 remains a delta carrier rather than a wholesale stale-tree replay.

Copy link
Copy Markdown
Contributor Author

Foundation ordering finding: #876 is the first still-live source RED for the criterion-coordinate stack. Exact 259e2d1ad8545bda75873a15c9e1b0de13996e4f still carries only tests/test_leftover_map_report_criterion_item_coordinate_contract.py; production leftoverMapPlotCriterionBadge/report-marker wiring is absent. Descendants #1033 and #1034 must not be promoted ahead of this prerequisite. Keep this Draft; repair must be causal on this branch, then descendants converge by ordinary non-force adoption with fresh exact-head evidence.

Copy link
Copy Markdown
Contributor Author

@coderabbitai full review

Please review the complete current diff from base c227823416aefb4539d993c64ec8d4d9e68e2ac5 through exact head d8b7f420bfb651f535c1b378b3d33ea71a6683a2. Focus on the report-graphic criterion coordinate boundary: ζ must come only from the marker's persisted finite item-axis pair via formatLeftoverMapCoordinatePair, preserve zero, fail closed for invalid pairs, and remain distinct from comparison naming. Please flag any a11y/i18n or contract mismatch. This review does not replace required repository/security/browser gates.

seonghobae added a commit that referenced this pull request Sep 17, 2026
seonghobae added a commit that referenced this pull request Sep 20, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant