test(reports): reconstruct #878 comparison criterion-coordinate contract - #1033
Conversation
…on graphic leftover-map criterion markers independently of leftover-map post ξ markers (v2.93.0) Caption leftover-map comparison graphic leftover-map criterion markers with persisted leftover-map item coordinates through leftoverMapComparePlotCriterionBadge independently of leftover-map post ξ markers (ADR 0336). Rank-0 unused axes still name leftover-map item coordinates (0.00, 0.00). A missing or non-finite leftover-map item coordinate pair omits independently of leftover-map post ξ. Do not invent leftover-map item coordinates from leftover-map post ξ. UI-only; no SQL; never invent a leftover score or a theta.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (3)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthrough비교 그래픽에 전용 기준 배지 생성기를 추가했습니다. 비교 변형은 생성된 배지를 우선 사용하고, 좌표가 없으면 기존 표시를 유지합니다. 접근성 이름 규칙과 관련 소스 계약 테스트도 갱신했습니다. Changes비교 기준 배지
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Bug fix Merge Risk: ⚪ Minimal · up to The comparison graphic now exposes its criterion coordinates through a dedicated accessible label while preserving safe behavior for absent or invalid coordinates. No actionable current-head risk remains. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
seonghobae
added
bug
ChatGPT Codex Connector
|
Reconstruction authority has moved non-force with its live parent. Exact head is now |
|
@coderabbitai full review Please review the complete current diff from base |
🧩 Analysis chain🏁 Script executed: #!/bin/bash
set -euo pipefail
base='d8b7f420bfb651f535c1b378b3d33ea71a6683a2'
head='1b3ce95e7b3850f4dd48ff883bc6c2da83319321'
git rev-parse --verify "${base}^{commit}"
git rev-parse --verify "${head}^{commit}"
printf '\n== Changed files and diffstat ==\n'
git diff --stat "$base" "$head"
git diff --name-status "$base" "$head"
printf '\n== Complete diff ==\n'
git diff --find-renames --find-copies --no-ext-diff "$base" "$head"
printf '\n== Coordinate/action references at exact head ==\n'
git grep -n -I -E 'formatLeftoverMapCoordinatePair|leftoverMapComparePlotCriterionBadge|leftoverMapPlotCriterionBadge|leftover map comparison graphic leftover-map criterion|ζ|zeta|coordinate' "$head" -- ':!node_modules' ':!dist' ':!build' || trueLength of output: 240592 🏁 Script executed: #!/bin/bash
set -euo pipefail
printf '%s\n' '== Coordinate formatter =='
sed -n '1,65p' frontend/src/leftoverMapCoordinates.ts
printf '%s\n' '== Layout helpers and imports =='
sed -n '1,85p' frontend/src/leftoverMapPlotLayout.ts
printf '%s\n' '== Criterion text and component interfaces =='
sed -n '1,190p' frontend/src/components/LeftoverMapPlot.tsx
printf '%s\n' '== Translation helper definitions and fallback behavior =='
rg -n -A18 -B8 -P '\bfunction\s+(?:t|tf)\b|\bconst\s+(?:t|tf)\b|\b(?:t|tf)\s*=' frontend/src frontend/src/components -g '*.ts' -g '*.tsx' | head -240
printf '%s\n' '== Existing LeftoverMapPlot comparison tests =='
rg -n -A18 -B8 -P '\bcomparison\b|Criterion ζ|leftover map comparison graphic leftover-map criterion' frontend/src/components/LeftoverMapPlot.test.tsx frontend/src/leftoverMapPlotLayout.test.ts || true
printf '%s\n' '== New action-key translation entries =='
rg -n -F 'leftover map comparison graphic leftover-map criterion {label} at ζ {item}' frontend/src/i18n.ts frontend/src/i18n.test.ts || trueLength of output: 179005 🏁 Script executed: #!/bin/bash
set -euo pipefail
printf '%s\n' '== Signed formatter =='
rg -n -A25 -B8 -P '\bfunction\s+formatSignedLeftoverValue\b' frontend/src/leftoverMapUnexplained.ts
printf '%s\n' '== Criterion marker render path =='
sed -n '470,555p' frontend/src/components/LeftoverMapPlot.tsx
printf '%s\n' '== Direct tests for criterion marker action names =='
rg -n -A12 -B8 -P 'criterion.*(?:marker|accessible|label)|getByLabelText\(.*criterion|LEFTOVER_MAP_(?:COMPARE_)?PLOT_CRITERION|leftoverMap(?:Compare)?PlotCriterionBadge' \
frontend/src/components/LeftoverMapPlot.test.tsx frontend/src/leftoverMapPlotLayout.test.ts \
frontend/src/leftoverMapCoordinates.test.ts || true
printf '%s\n' '== Complete modification line numbers =='
git diff --unified=0 d8b7f420bfb651f535c1b378b3d33ea71a6683a2 1b3ce95e7b3850f4dd48ff883bc6c2da83319321 -- \
frontend/src/components/LeftoverMapPlot.tsx frontend/src/leftoverMapPlotLayout.ts \
tests/test_grouping_comparison_graphic_criterion_item_coordinate_contract.pyLength of output: 10428
I found no blocking issues in the inspected diff. The comparison criterion marker now has a distinct action key. The comparison path uses The formatter rejects nullish and non-finite coordinates. It preserves finite zero coordinates as I did not run repository, security, browser, accessibility, or performance gates. Keep the PR in Draft until those fresh exact-head checks and qualifying independent approval are available. ✅ Action performedFull review finished. |
|
@coderabbitai full review Re-review the complete current diff from base |
🧩 Analysis chain🏁 Script executed: #!/bin/bash
set -euo pipefail
base='7fbcc5e326ce168b95182784284c97a539639244'
head='e4146b5c88caac94968da67976ca0f8973186aae'
git rev-parse --verify "${base}^{commit}"
git rev-parse --verify "${head}^{commit}"
printf '%s\n' '== Changed files and diffstat =='
git diff --stat "$base" "$head"
git diff --name-status "$base" "$head"
printf '%s\n' '== Complete diff =='
git diff --find-renames --find-copies --no-ext-diff "$base" "$head"
printf '%s\n' '== Relevant files at requested head =='
git ls-tree -r --name-only "$head" | rg '(^|/)(LeftoverMapPlot\.tsx|leftoverMapPlotLayout\.ts|leftoverMapCoordinates\.ts|i18n\.ts|.*[Tt]est.*\.(ts|tsx|py))$' | head -250
printf '%s\n' '== Relevant identifiers at requested head =='
git grep -n -I -E 'leftoverMapComparePlotCriterionBadge|leftoverMapPlotCriterionBadge|formatLeftoverMapCoordinatePair|LEFTOVER_MAP_(COMPARE_)?PLOT_CRITERION|Criterion ζ|comparison graphic|leftover_map_person_axis|Math\.(sqrt|abs)|coordinate' "$head" -- 'frontend' 'tests' || true
printf '%s\n' '== Commit ancestry =='
git merge-base --is-ancestor "$base" "$head" && echo 'base is an ancestor of head' || echo 'base is NOT an ancestor of head'
git log --oneline --decorate -12 "$base..$head"Length of output: 160431 🏁 Script executed: #!/bin/bash
set -euo pipefail
head='e4146b5c88caac94968da67976ca0f8973186aae'
printf '%s\n' '== Coordinate formatter =='
git show "$head:frontend/src/leftoverMapCoordinates.ts" | nl -ba | sed -n '1,70p'
printf '%s\n' '== Layout criterion helpers and marker construction =='
git show "$head:frontend/src/leftoverMapPlotLayout.ts" | nl -ba | sed -n '1,80p'
git show "$head:frontend/src/leftoverMapPlotLayout.ts" | nl -ba | sed -n '200,245p'
git show "$head:frontend/src/leftoverMapPlotLayout.ts" | nl -ba | sed -n '360,430p'
printf '%s\n' '== Component criterion text and render path =='
git show "$head:frontend/src/components/LeftoverMapPlot.tsx" | nl -ba | sed -n '80,120p'
git show "$head:frontend/src/components/LeftoverMapPlot.tsx" | nl -ba | sed -n '270,310p'
git show "$head:frontend/src/components/LeftoverMapPlot.tsx" | nl -ba | sed -n '490,545p'
printf '%s\n' '== All runtime references to comparison criterion static key =='
git grep -n -I -F 'LEFTOVER_MAP_COMPARE_PLOT_CRITERION' "$head" -- 'frontend' 'tests' || true
printf '%s\n' '== Translation API behavior =='
git show "$head:frontend/src/i18n.ts" | nl -ba | sed -n '1,90p'
git show "$head:frontend/src/i18n.ts" | rg -n -A14 -B5 'export function (t|tf)|function (t|tf)|const (t|tf)' | head -180
printf '%s\n' '== Criterion tests and changed executable contract =='
git show "$head:frontend/src/components/LeftoverMapPlot.test.tsx" | rg -n -A22 -B8 'criterion|Criterion ζ|non-finite.*item|item.*non-finite|item.*coordinate' | tail -300
git show "$head:tests/test_grouping_comparison_graphic_criterion_item_coordinate_contract.py" | nl -ba
git show "$head:tests/test_leftover_map_report_criterion_item_coordinate_contract.py" | nl -ba
printf '%s\n' '== Dynamic translation calls in changed files =='
git show "$head:frontend/src/components/LeftoverMapPlot.tsx" | rg -n '\b(t|tf)\('
git show "$head:frontend/src/leftoverMapPlotLayout.ts" | rg -n '\b(t|tf)\(' || trueLength of output: 45932
I found no blocking issues in the inspected diff. The comparison marker uses The comparison helper derives ζ only with The comparison path does not use ξ, geometry, distance, rank, coverage, or neighboring values to derive ζ. The comparison accessible name composes the existing localized I did not run repository, security, browser, accessibility, or performance gates. These gates remain required separately.
|
…son tick contract
This branch has not been deployed
1 participant
Current exact authority — 2026-09-21
473d5f20d69584db3eaa7e129f7a8650ecd472bb459b8af62763b6900cb0cb163fe3a64ea81fdaa50c1a97266f74b6963a765b7b78830146687861e9This reconstruction preserves the stronger comparison criterion-coordinate/tick-evidence contracts on the repaired report ancestry. The current head directly inherits #876 and, through current #861
69bdb2fc..., retains the exact σ+share App expectation repair, right-bounded axis captions, responsive screenshot evidence, and numeric tick identity. The historical Tests35449469635Vitest mismatch belonged to predecessordc9efcb0...and remains causal history only; it is no longer a current source contradiction.#1034 inherits this exact head by ordinary/non-force ancestry and carries only its four post-coordinate/accessibility deltas. Fresh exact-head repository/browser/accessibility/security evidence and independent review remain required; no predecessor receipt transfers.