feat(reports): leftover-map distance on grouping comparison graphic (v2.76.0) - #859
seonghobae wants to merge 10 commits into
Conversation
…v2.76.0)
Caption persisted leftover-map distance d on the grouping
comparison leftover-map graphic from already-named leftover_distance
(ADR 0319). Comparison copy uses leftover map comparison graphic leftover-map
distance {label} so it stays distinct from leftover-map distance {label}.
A missing or non-finite d omits that caption and keeps leftover-map rank,
leftover expected, leftover observed, leftover residual, leftover-map unexplained leftover,
leftover-map reconstruction, and comparison graphic coverage notes.
Rank-0 origin cells still name d 0.00 when that leftover-map distance is finite.
Do not caption leftover-map coordinate ticks this increment.
Do not invent leftover-map distance from plotted coordinates. Never invent a leftover score.
Never invent a theta. No new columns.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Exact head |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
|
Cycle 2026-08-31T00:18Z. Exact head Next buyer increment (explicitly deferred in ADR 0319): leftover-map coordinate ticks on the grouping comparison leftover-map graphic with a distinct comparison-graphic accessible name (ADR 0320 / v2.77.0), stacked on this head. Period-report ticks already sit through ADR 0270. Do not invent leftover-map distance from plotted coordinates. Never invent a leftover score. Never invent a theta. No new columns. Synthetic fixtures only. |
|
Cycle 2026-08-31T00:28Z. Exact head |
seonghobae
added
enhancement
ChatGPT Codex Connector
Adopt exact reconstructed #858 as the current tree while preserving historical #859 as first parent. Retain the v2.76 distance product delta as executable RED: the comparison graphic must name persisted leftover_distance with distinct comparison copy, omit only missing/non-finite evidence, preserve finite zero/signed values, and never derive distance from plot geometry. Exact #858 is the second parent. No force update or destructive rebase.
Adopt exact reconstructed #859 as the current tree while preserving historical #860 as first parent. Retain the v2.77 coordinate-tick product delta as executable RED: comparison ticks need distinct accessible copy and must come only from the origin plus persisted ξ/ζ projections, never from leftover distance or fabricated spacing. Exact #859 is the second parent. No force update or destructive rebase.
Adopt exact repaired #858 head 0a10ded without force-updating or replaying stale historical source. Preserve the existing #859 reconstruction as first parent, carry its executable distance RED unchanged, and take the repaired #858 tree as the second parent so the descendant no longer drops the rank accessible-name fix.
2026-09-13 current-head authorityThe stale comparison-only consumer assertions have now been causally repaired on exact head All active repaired descendants were then non-force converged in ancestry, including the serialized #860→#875 chain, both #875 forks (#876 and #877), and reconstructed successors #1033→#1034. Historical #878/#879 remain open delta carriers; their valid product intent is preserved through the reconstructed successor ancestry rather than wholesale replay of their stale source/docs trees. No predecessor validation receipt transfers. Fresh validation is not yet GREEN. Tests runs on this head were disturbed by the temporary convergence PR lifecycle: |
This branch has not been deployed
1 participant
Summary
Caption persisted leftover-map distance
don the grouping-comparison leftover-map graphic from already-namedleftover_distance(ADR 0319 / v2.76.0), without adding a comparison-only static translation key.Current exact authority
d207b04ff3a44ff66e995c7435328cbfba5b07a92550e8d88339e30297fa0aa19ffae77f9b78b73bProposedRED → causal repair
The earlier contract incorrectly demanded a new English-only
LEFTOVER_MAP_COMPARE_PLOT_SEGMENT_DISTANCE, repeating localization debt already repaired in #858. Production intentionally composes the already-localized comparison-graphic label with the generic localized distance label, so comparison accessible names are distinct from report-mode names without a new static key.The remaining executable RED was eight comparison-only omission cases in
frontend/src/components/LeftoverMapPlot.test.tsx: 16 exact assertions still expected report-modeleftover-map distance d …while comparison production returnedLeftover map comparison graphic: leftover-map distance d ….Exact head
2550e8d...is the minimal repair. It changes only those 16 comparison assertions; report-mode assertions and production semantics are unchanged. The bounded repair workflow removed itself before publishing the product head. Distance still comes only from persistedpair.leftover_distance; missing/non-finite values omit the caption and finite zero/signed values remain data-driven and unclamped.Descendant convergence
All active repaired descendants were non-force converged onto this ancestry in the same maintenance lane: the serialized #860→#875 chain, both #875 forks (#876 and #877), and reconstructed successors #1033→#1034. Historical #878/#879 remain open delta carriers; their valid product intent is preserved through reconstructed successor ancestry rather than wholesale replay of stale source/docs trees. No predecessor validation receipt transfers.
Current validation
Fresh validation on
2550e8d...is not GREEN:34752865986: terminal FAILURE with zero jobs;34752892232: CANCELLED during descendant convergence activity;34752900076: SKIPPED;.github#2045;Do not interpret the zero-job/cancelled/skipped runs as product-test evidence. Promotion requires fresh exact-head repository/frontend/browser-a11y/performance/security evidence plus qualifying independent approval after the canonical lifecycle owner can materialize/reconcile the required identities.
Translation-owner boundary
Issue #922 / PR #929 remain the canonical versioned translation-ledger path. This PR adds no DB schema, comparison-only translation resource, cross-service SQL, provider/model dependency, or competing translation authority.
No self-approval, bypass, force push, destructive rebase, ancestor skip, stale-evidence transfer, hidden compatibility label, historical-tree replay, source-neutral validation churn or repeated Draft/Ready toggling.