Skip to content

feat(reports): leftover-map origin on leftover-map comparison graphic leftover-map axis ticks independently of leftover-map axis share and leftover-map singular values (v2.92.0) - #877

Draft
seonghobae wants to merge 40 commits into
feat/leftover-map-axis-tick-share-badge-v2910from
feat/leftover-map-compare-plot-tick-origin-badge-v2920
Draft

seonghobae wants to merge 40 commits into
feat/leftover-map-axis-tick-share-badge-v2910from
feat/leftover-map-compare-plot-tick-origin-badge-v2920

Conversation

@seonghobae

@seonghobae seonghobae commented Aug 31, 2026 •

Copy link
Copy Markdown
Contributor

Current exact authority — 2026-09-21

Ordinary/non-force sibling convergence preserves the six-file comparison-origin/i18n delta on repaired #875 ancestry without copying #876 criterion-coordinate ownership. No predecessor receipt transfers.

… leftover-map axis ticks (v2.92.0)

Caption leftover-map comparison graphic leftover-map axis origin ticks through leftoverMapComparePlotTickAxisBadge independently of leftover-map axis share and leftover-map singular values (ADR 0335). Origin 0.00 stays leftover map comparison graphic leftover-map axis {k} origin tick {value} so buyers can tell the rank-0 unused-axis location from leftover-map coordinate ticks. Share and σ omit independently. Do not invent leftover-map origin from share or σ. UI-only; no SQL; no leftover-map inner product, cosine, or length.
@coderabbitai

coderabbitai Bot commented Aug 31, 2026 •

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: f6f80f15-34b2-4b60-93a8-e677f691b7df

📥 Commits

Reviewing files that changed from the base of the PR and between 70b81b3 and a61db0a.

📒 Files selected for processing (3)
  • frontend/src/components/LeftoverMapPlot.tsx
  • frontend/src/leftoverMapPlotAxisSingular.ts
  • tests/test_grouping_comparison_graphic_tick_contract.py

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

비교 그래프의 축과 틱 레이블이 공유율과 특이값 증거를 독립적으로 반영한다. 원점은 형식화된 0 좌표와 정확히 비교한다. 틱 aria-label은 새 배지 조합 로직을 사용한다.

Changes

비교 그래프 틱 레이블

Layer / File(s) Summary
틱 배지 판정 로직
frontend/src/leftoverMapPlotAxisSingular.ts, tests/test_grouping_comparison_graphic_origin_tick_contract.py
공유율·특이값 조합별 번역 키와 배지 타입을 추가했다. 원점은 formatSignedLeftoverValue(0)의 결과와 틱 레이블을 비교해 판정한다. 계약 테스트는 네 가지 원점 문구와 판정 조건을 확인한다.
플롯 축과 aria-label 연결
frontend/src/components/LeftoverMapPlot.tsx, tests/test_grouping_comparison_graphic_tick_contract.py
비교 플롯의 축 배지와 틱 aria-label이 저장된 공유율·특이값을 사용하도록 변경했다. 보고서 플롯은 기존 틱 템플릿을 유지한다.

Priority: ⬇️ Low

Estimated code review effort: 3 (Moderate) | ~20 minutes

Change: Feature

Merge Risk: ⚪ Minimal · up to a61db

The updated comparison tick behavior has no confirmed unresolved defect in the supplied scope.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed Docstring coverage is 90.91% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 11 functions across 4 files.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed 제목은 비교 그래픽의 원점 틱 처리와 leftover-map axis share 및 singular value의 독립 처리를 정확히 설명합니다. 다만 반복 표현과 버전 정보로 인해 길고 읽기 어렵습니다.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/leftover-map-compare-plot-tick-origin-badge-v2920

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copy link
Copy Markdown
Contributor Author

Leave this PR open for independent APPROVE. Do not squash-merge onto the unprotected leftover base. Do not self-approve. Devin/Copilot COMMENT is not APPROVE.

Stacked onto leftover-axis tick leftover-map axis share (feat/leftover-map-axis-tick-share-badge-v2910 / #875 @ d19f1fd). After independent review, retarget leftover-map stack onto leftover-coordinates (feat/leftover-map-coordinates-v2240 / #782) rather than squash-merging here. Issues #79 and #87 stay open. Do not merge #808 without independent APPROVE.

Cycle 2026-08-31 16:22 KST: GitHub writes work as seonghobae. #96 already closed (duplicate of #91). #875 left open (Devin COMMENTED, not APPROVE). This increment is leftover-map origin on leftover-map comparison graphic leftover-map axis ticks (ADR 0335 / v2.92.0). oxlint + tsc -b + vitest leftover-map + App + i18n 737 passed. Never invent leftover/theta. Do not persist leftover-map inner product, cosine, or length.

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 potential issue.

Devin Review

Comment thread frontend/src/leftoverMapPlotAxisSingular.ts
This was referenced Aug 31, 2026
seonghobae added a commit that referenced this pull request Sep 3, 2026
…r-axis independently of leftover-map comparison graphic leftover-map origin (v2.114.0)

Caption leftover-map comparison leftover-axis leftover-map origin through leftoverMapCompareAxisOriginBadge (ADR 0357). Distinct accessible name leftover map comparison leftover axis leftover-map origin {origin}. Rank-0 unused axes still name leftover-map origin (0.00, 0.00). leftoverMapAxisOriginBadge stays unnamed. No SQL. Do not invent leftover-map origin from ζ, leftover-map axis share, or σ_k. Do not mix #877. Do not mix #890.

Copy link
Copy Markdown
Contributor Author

Current repair-writer authority — 2026-09-16

  • target product head remains exact ddaa592ab2b3bbd6a50d267fee3e794f0925448e on feat(reports): leftover-map axis share on leftover-axis ticks independently of leftover-map singular values (v2.91.0) #875 18448d394ad6d66f0d0650d3c906c12b5460758c.
  • existing single-writer branch automation/877-tick-i18n-20260916 was retargeted non-destructively to that exact head at automation commit 3750fc01b8ef9e173915a475f452d4ca6b560b30.
  • current one-shot run 35053146771, job 104657654443, is queued before any steps have materialized. It is the sole current writer for the 32 ko/zh/ja/vi comparison-tick accessibility catalog entries.

The workflow keeps the RED contract first, applies only the missing static catalog entries, runs the three focused tick/origin/i18n contracts, then exact-head guards commit/push and deletes its one-shot automation branch on success. Do not create a second source writer, no-op wake commit, or inherit the failed predecessor workflow as GREEN. If the target head moves first, the guard must fail closed and the current ancestry must be adopted again.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant