feat(reports): leftover-map singular values on leftover-axis report badges independently of leftover-map axis share (v2.82.0) - #866
Conversation
…adges independently of leftover-map axis share (v2.82.0)
Caption leftover-axis report badges with persisted leftover-map singular
values σ_k independently of leftover-map axis share (ADR 0325). Period
leftover-axis copy stays leftover axis {k} σ {value} when share is omitted
so it stays distinct from leftover-axis leftover axis {k} σ {value} {share}%,
from hyphen leftover-map axis {k} σ {value}, from comparison leftover-axis
leftover map comparison leftover axis {k} σ {value}, and from comparison
graphic leftover map comparison graphic leftover-map axis {k} σ {value}.
Rank-0 unused axes still name σ 0.00. Share and singular value omit
independently. Do not invent σ_k from leftover-map axis share. Do not invent
leftover-map axis share from σ_k. Never invent a leftover score. Never invent
a theta.
📝 WalkthroughWalkthrough남은 축 배지가 singular 값과 share 값의 유무를 독립적으로 처리합니다. share가 없으면 singular-only 배지를 생성하고, 유효하지 않은 값은 표시하지 않습니다. 관련 테스트, ADR, 변경 로그를 추가했습니다. Changes남은 축 배지 투영
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~15 minutes Change: Feature Merge Risk: 🔵 Low · up to Reports can show an empty leftover-axis badge when neither persisted value is usable. Route rendering through the new projection before merging. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Cycle 2026-08-31 11:16 KST. Writes work as seonghobae. Exact head |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
|
Cycle 2026-08-31 11:16 KST. Writes work. Exact head Next buyer increment after this stacked σ_k surface: leftover-map comparison graphic leftover-map axis leftover-map singular values as leftoverMapComparePlotAxisBadge (named helper matching leftoverMapPlotAxisBadge / leftoverMapCompareAxisBadge / leftoverMapAxisBadge), or leftover-map graphic leftover-map axis ticks naming persisted σ_k independently of leftover-map axis share, or the next already-persisted leftover-map quantity that still has no buyer caption. Do not persist leftover-map inner product, cosine, or length. Synthetic fixtures only. |
seonghobae
added
enhancement
ChatGPT Codex Connector
Adopt exact reconstructed #865 as the current tree while preserving historical #866 as first parent. Retain the v2.82 singular-only product delta as executable RED: a valid persisted σ must remain visible when share is absent, σ/share missingness stays independent, and neither value may be inferred from the other. Exact #865 is the second parent. No force update or destructive rebase.
Adopt exact reconstructed #866 as the current tree while preserving historical #867 as first parent. Retain the v2.83 product delta as executable RED: comparison-graphic axes must preserve persisted σ when share is missing and keep σ/share states independent, without inference or clamping. Exact #866 is the second parent. No force update or destructive rebase.
Ordinary non-force ancestry adoption. Preserve #866 report-axis singular-only contract delta while inheriting repaired comparison-distance assertions.
Ordinary non-force ancestry adoption. Preserve the #866 singular-only report-axis contract while inheriting the repaired singular projection chain.
Ordinary non-force ancestry adoption. Preserve the #867 comparison-graphic axis badge contract while inheriting the repaired singular projection chain.
seonghobae
left a comment
seonghobae
left a comment
There was a problem hiding this comment.
Current-head RCA closes the automation ambiguity but not the product RED. Run 35016883619 checked out the predecessor RED, confirmed it, staged the correct minimal App.tsx change, and then failed only because the older contract required comma-sensitive import punctuation; commit/push was skipped. Concurrent ordinary commit 047cefc5b439cf4f4c8e33ca0585ac4b4ca26a3b repairs that harness only. Current App.tsx still bypasses leftoverMapAxisBadge(axis), so the executable contract remains RED and the buyer-visible empty-badge defect remains. Apply the already-proven minimal consumer change against exact 047cefc5...: import leftoverMapAxisBadge, map each axis through it, return null for a null projection, otherwise render tf(badge.template, badge.values). Do not alter helper semantics or thresholds.
| assert "badge === null ? null" in app_source | ||
| assert "tf(badge.template, badge.values)" in app_source | ||
| assert "leftoverMapAxisBadgeShare" not in app_source | ||
| assert "leftoverMapAxisBadgeSingular" not in app_source |
There was a problem hiding this comment.
This exact-head contract is now intentionally semantic rather than comma-sensitive, but production App.tsx is still RED. The earlier one-shot run already demonstrated the causal patch in-workspace; it never pushed because the predecessor test itself rejected import punctuation. Please apply only that consumer repair now: use leftoverMapAxisBadge(axis), omit null projections, and render tf(badge.template, badge.values) otherwise. Preserve all existing helper behavior.
|
Rate Limit Exceeded. |
|
Current repair-writer authority after the harness-only head movement:
Do not add a competing source writer, no-op wake commit, blind rerun, or |
a51b0ec
into
feat/leftover-map-plot-axis-singular-v2810
1 participant
Final authority — merged 2026-09-20
feat/leftover-map-plot-axis-singular-v28108d63271c4644b39d11d65263cc59e8fca8a548cda51b0ec4668fa4bef4cd45dfd777fe3df8871331This lane owned the report-axis singular-only contract repair: three-state copy (share only, singular only, singular+share), independent formatter delegation, and no σ/share derivation. Its valid product/test/ADR/CHANGELOG delta is now materially present in #865; this is not a simple Close or successor substitution.
The former child #867 has been retargeted from this closed branch to active #865 after verifying #865
a51b0ec...is its exact merge-base andbehind_by=0. Pre-merge workflow receipts do not transfer to #865 or descendants.