Skip to content

fix: retain bounded Bugbot response diagnostics - #939

Merged
3 commits merged into
developfrom
bugfix/920-bugbot-partition-exhausts-unusable-output-retries-without-a-diagnostic-reason
Nov 8, 2026
Merged

3 commits merged into
developfrom
bugfix/920-bugbot-partition-exhausts-unusable-output-retries-without-a-diagnostic-reason

Conversation

@efraespada

@efraespada efraespada commented Nov 8, 2026 •

Copy link
Copy Markdown
Member

Closes #920.

A Bugbot partition could exhaust three attempts and lose the completed-response validation cause behind a generic agent failure. Native detection and candidate-verification JSON/schema failures and host candidate-proof rejections now retain a closed reason through that same fixed allowance. Exhaustion publishes the final reason and attempt count as non-retryable, without retaining rejected output.

What changed

  • Preserve source assignments, schema, paired verification, capacity, freshness and atomic review gates. Provider/process errors and structural lookalikes keep their previous identity.
  • Add validated public diagnostics, English/Spanish/fallback guidance, real documentation examples and permanent 100% coverage budgets for the new pure modules.
  • Keep the historical Domus failure unclassified: its retained logs do not prove which output boundary failed. A later green retry does not identify that cause.

Validation

Native RED reproduction before implementation; 15 new declared cases plus existing preservation controls. Full root coverage: 913 suites / 18,215 tests passed, 35 existing skips, all budgets and setup ledger passed. Extension: 385 suites / 5,289 tests and 100% of every coverage metric. New pure modules have 100% of every metric. Type/lint, spec/catalog, documentation/workflow contracts, packaged CLI/API/web smoke and normal build/test/lint commit hooks passed.

Review notes

Current-head remote CI/review and official correct-base Codecov remain required. Related #937 / PR #938 addresses the separate progress-generation pipeline and is still undergoing native Domus qualification. This PR adds no release, tag, model call or execution authority.

…a-diagnostic-reason: retain bounded Bugbot response diagnostics (#920)
@docs-page

docs-page Bot commented Nov 8, 2026

Copy link
Copy Markdown

To preview the documentation for this pull request, visit the following URL:

docs.page/vypdev/copilot~939

Documentation is deployed and generated using docs.page

@vypbot
vypbot self-requested a review November 8, 2026 02:48
@vypbot vypbot added this to vypdev Nov 8, 2026
@vypbot vypbot moved this to In Progress in vypdev Nov 8, 2026
@vypbot vypbot added the size: XXL Indicates an extremely large task or issue that requires significant time and effort to complete. label Nov 8, 2026
@vypbot
vypbot changed the base branch from develop to master November 8, 2026 02:48
@vypbot
vypbot changed the base branch from master to develop November 8, 2026 02:49
@vypbot vypbot added the 85% Progress: 85% label Nov 8, 2026
@vypbot

vypbot commented Nov 8, 2026 •

Copy link
Copy Markdown
Contributor

Bugbot: review complete

Current status: No active findings on 5347be2.

Pull request · Verified commit · Workflow run

@vypbot

vypbot commented Nov 8, 2026 •

Copy link
Copy Markdown
Contributor

Copilot approval · Human review needed

Status: A protected workflow, policy, or trust-boundary file changed.
Completed: 1/1 observed checks succeeded; Bugbot complete.
Action required: Ask a human reviewer to decide.
Impact: No new approval is confirmed for this revision.
See checks

Technical evidence

Revision: 5347be2ff59b; base: 8db3f6819cca; reason: protected-path.

@codecov-commenter

codecov-commenter commented Nov 8, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.07%. Comparing base (239a04f) to head (5347be2).
⚠️ Report is 147 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #939      +/-   ##
===========================================
+ Coverage    95.25%   96.07%   +0.82%     
===========================================
  Files         1172     1521     +349     
  Lines        39236    47281    +8045     
  Branches     11685    14709    +3024     
===========================================
+ Hits         37373    45426    +8053     
  Misses         698      698              
+ Partials      1165     1157       -8     
Files with missing lines Coverage Δ
...ion/errors/bugbot_verification_response_failure.ts 100.00% <100.00%> (ø)
...tion/policies/application_error_message_catalog.ts 100.00% <ø> (ø)
...ion/policies/bugbot_literal_verification_policy.ts 100.00% <100.00%> (ø)
...cases/steps/commit/bugbot/query_bugbot_findings.ts 97.56% <100.00%> (+0.26%) ⬆️
...commit/bugbot/verify_generated_literal_findings.ts 100.00% <100.00%> (ø)
src/data/model/application_error.ts 100.00% <100.00%> (ø)
.../data/repository/agent_findings_response_policy.ts 96.00% <100.00%> (+11.38%) ⬆️
src/domain/bugbot/response_failure.ts 100.00% <100.00%> (ø)

... and 177 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

…a-diagnostic-reason: parse diagnostic documentation on Windows (#920)
…a-diagnostic-reason: fetch the pinned driver through its immutable asset API (#920)
@vypbot vypbot added state:ai-processing 100% Progress: 100% and removed 85% Progress: 85% state:ai-processing labels Nov 8, 2026
@efraespada efraespada closed this pull request by merging all changes into develop in 5bee5ef Nov 8, 2026
@github-project-automation github-project-automation Bot moved this from In Progress to Done in vypdev Nov 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

100% Progress: 100% size: XXL Indicates an extremely large task or issue that requires significant time and effort to complete. state:verified

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

🐛🧑‍💻 - Bugbot partition exhausts unusable output retries without a diagnostic reason

3 participants