Skip to content

Fix bounded progress generation and review recovery diagnostics - #938

Merged
efraespada merged 12 commits into
developfrom
bugfix/937-released-acceptance-recovery-exhausts-on-r11-in-three-unchanged-domus-evaluations
Nov 8, 2026
Merged

efraespada merged 12 commits into
developfrom
bugfix/937-released-acceptance-recovery-exhausts-on-r11-in-three-unchanged-domus-evaluations

Conversation

@efraespada

@efraespada efraespada commented Nov 8, 2026 •

Copy link
Copy Markdown
Member

Closes #937. Closes #920. Closes #870. Closes #911.

Large progress comparisons now allocate exact JSON UTF-8 quotas per field in both framed profiles. Final multi-batch assessments use closed semantic decisions and complete host-rendered labels within the original requirement and text bounds. Unicode and byte failures share the existing single replacement; exhausted generation stops with a nonretryable diagnostic. Source identity, locale, receipts, freshness and publication checks remain enforced.

Bugbot preserves a finite diagnostic reason after its existing three unusable completed responses. Freshness failures identify the trusted read operation and known HTTP metadata, distinguish before/after publication and reject malformed heads. Recovery rechecks the current head and reconciles persisted findings without duplicate publication. Protected-path and over-limit synchronization refusals preserve their policy and expose safe counts and complete English/Spanish actions.

Related operational fixes cover the native fixture stdin race, CRLF extraction, checksum-bound downloads of the same reviewed JDK/driver archives, and explicit generated-artifact conflicts so rebuilding finishes before synchronization verification. The Action published the verified combination with #939; normal contributor changes prepared the reviewed workflow while preserving bot credentials and Action-owned merging.

Validation: 920 root suites / 18,293 passing tests (35 existing platform skips); 385 extension suites / 5,289 passing tests at 100% on every metric. All coverage/acceptance budgets, types, lint, specification/catalog, documentation/workflow contracts, build, typed package/CLI/API/web smoke and normal hooks pass. The actual-base local diff audit covers all 260 changed executable lines with zero misses or partial branches; new freshness policies/helpers have 100% on every metric.

Native consumer qualification and the 18-issue audit are recorded in #937 and Domus PR #29. Merge gates apply to the exact final head: applicable CI, official Codecov, native consumer verification and zero active review findings. Domus feature completion and merge remain separate from SDK qualification.

…anged-domus-evaluations: generate bounded complete progress facts (#937)
@docs-page

docs-page Bot commented Nov 8, 2026

Copy link
Copy Markdown

To preview the documentation for this pull request, visit the following URL:

docs.page/vypdev/copilot~938

Documentation is deployed and generated using docs.page

@vypbot vypbot added size: XXL Indicates an extremely large task or issue that requires significant time and effort to complete. state:ai-processing labels Nov 8, 2026
@vypbot
vypbot self-requested a review November 8, 2026 02:04
@vypbot vypbot added this to vypdev Nov 8, 2026
@vypbot vypbot moved this to In Progress in vypdev Nov 8, 2026
@vypbot
vypbot changed the base branch from develop to master November 8, 2026 02:04
@vypbot
vypbot changed the base branch from master to develop November 8, 2026 02:05
@vypbot vypbot added the 70% Progress: 70% label Nov 8, 2026
@vypbot

vypbot commented Nov 8, 2026 •

Copy link
Copy Markdown
Contributor

Bugbot: review complete

Current status: No active findings on 0efaba9.

Pull request · Verified commit · Workflow run

@vypbot

vypbot commented Nov 8, 2026 •

Copy link
Copy Markdown
Contributor

Copilot approval · Human review needed

Status: This pull request is outside the configured approval scope.
Completed: 1/1 observed checks succeeded; Bugbot complete.
Action required: Ask a human reviewer to decide.
Impact: No new approval is confirmed for this revision.
See checks

Technical evidence

Revision: 0efaba9412a4; base: 8db3f6819cca; reason: scope.

@codecov-commenter

codecov-commenter commented Nov 8, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.09%. Comparing base (239a04f) to head (0efaba9).
⚠️ Report is 147 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #938      +/-   ##
===========================================
+ Coverage    95.25%   96.09%   +0.84%     
===========================================
  Files         1172     1526     +354     
  Lines        39236    47472    +8236     
  Branches     11685    14772    +3087     
===========================================
+ Hits         37373    45618    +8245     
+ Misses         698      697       -1     
+ Partials      1165     1157       -8     
Files with missing lines Coverage Δ
src/application/errors/bugbot_freshness_error.ts 100.00% <100.00%> (ø)
src/application/errors/bugbot_mutation_error.ts 100.00% <100.00%> (ø)
...ion/errors/bugbot_verification_response_failure.ts 100.00% <100.00%> (ø)
...tion/policies/application_error_message_catalog.ts 100.00% <ø> (ø)
.../policies/application_error_presentation_policy.ts 100.00% <100.00%> (ø)
...ion/policies/bugbot_literal_verification_policy.ts 100.00% <100.00%> (ø)
...tion/policies/progress_assessment_length_policy.ts 100.00% <ø> (ø)
...ion/policies/progress_compact_assessment_policy.ts 100.00% <100.00%> (ø)
...ication/policies/progress_partition_byte_policy.ts 100.00% <100.00%> (ø)
...ation/policies/progress_partition_length_policy.ts 100.00% <100.00%> (ø)
... and 22 more

... and 173 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

…a-diagnostic-reason: retain bounded Bugbot response diagnostics (#920)
…a-diagnostic-reason: parse diagnostic documentation on Windows (#920)
…anged-domus-evaluations: bound complete source facts by actual JSON bytes (#937)
…a-diagnostic-reason: fetch the pinned driver through its immutable asset API (#920)
@vypbot vypbot added state:ai-processing 65% Progress: 65% and removed state:ai-processing 70% Progress: 70% labels Nov 8, 2026
…anged-domus-evaluations: complete prompt delivery before native fixture exit (#937)
@vypbot vypbot added 55% Progress: 55% and removed state:ai-processing 70% Progress: 70% labels Nov 8, 2026
…thout-a-diagnostic-reason into bugfix/937-released-acceptance-recovery-exhausts-on-r11-in-three-unchanged-domus-evaluations
@vypbot

vypbot commented Nov 8, 2026

Copy link
Copy Markdown
Contributor

Branch synchronized

bugfix/920-bugbot-partition-exhausts-unusable-output-retries-without-a-diagnostic-reason was merged into bugfix/937-released-acceptance-recovery-exhausts-on-r11-in-three-unchanged-domus-evaluations and pushed as e9e1096e4bfc75ff06df783eac83f5b6e83f4f7e.

The fixer resolved 7 conflicted files.

6 verification checks passed.

…anged-domus-evaluations: diagnose freshness failures and ineligible sync conflicts
@efraespada efraespada changed the title fix: generate bounded semantic progress assessments Fix bounded progress generation and review recovery diagnostics Nov 8, 2026
@vypbot vypbot added 65% Progress: 65% and removed state:ai-processing 55% Progress: 55% labels Nov 8, 2026
…anged-domus-evaluations: wait for canonical catalog read completion
@vypbot vypbot added state:ai-processing 75% Progress: 75% and removed state:ai-processing 65% Progress: 65% labels Nov 8, 2026
…anged-domus-evaluations: serialize all catalog recovery reads
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

65% Progress: 65% size: XXL Indicates an extremely large task or issue that requires significant time and effort to complete. state:verified

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

🐛🧑‍💻 - Released acceptance recovery exhausts on R11 in three unchanged Domus evaluations

3 participants