Pin ReadStat_jll to 1.1.9, raise Julia floor to 1.10, fix wrapper defects

[davidanthoff]

Audit of what binary we actually ship, plus the wrapper defects it turned up.

We were not shipping the latest binary

ReadStat_jll 1.1.8 and newer require julia 1.6, but our julia floor was 1.3 and our bound was ReadStat_jll = "1.1.1" (i.e. [1.1.1, 2.0)). On julia 1.3-1.5 the resolver therefore fell back to ReadStat_jll 1.1.5, shipping the December 2020 readstat build instead of 1.1.9.

Pinned to "1.1.9" with julia = "1.10", matching Query.jl and ReadStatTables.jl. Raising the floor is breaking for old-julia users, so the version goes to 1.2.0-DEV.

For the record on the binary itself: 1.1.9 (2023-02-20) is still upstream's newest release, so we are now on the latest tag that exists. Upstream dev is 58 commits ahead and most other bindings (pyreadstat, haven, readstat-rs) have moved to pinned dev commits, but this PR deliberately stays on the released tag. Asking upstream to tag is being handled separately on WizardMac/ReadStat#343.

Wrapper defects

• Alignments were read from the wrong accessor. get_alignment called readstat_variable_get_measure, so ReadStatDataFrame.alignments was silently a copy of .measures. Every fixture reports measure UNKNOWN, so .dta and .xpt were reporting all-zero alignments where readstat actually says RIGHT. The correct accessor was already wrapped in C_interface.jl but never called.
• The two get_type methods disagreed about READSTAT_TYPE_STRING_REF: one mapped it to String, the other fell through to Nothing. Not reachable today - the dta reader rewrites STRING_REF to STRING before the handlers ever see it, and no other reader mentions the type - so this removes a trap rather than fixing a live bug. Both now share one lookup table, which also picks up the modern enum spelling: upstream renamed CHAR to INT8 and LONG_STRING to STRING_REF, values unchanged.
• ccall signatures. The four readstat_set_*_handler calls declared Int (64-bit) where C returns a 4-byte enum; harmless only because the values are discarded. readstat_get_modified_time was declared UInt where C returns signed time_t, so a pre-1970 timestamp became a huge positive number that unix2datetime choked on.
• Dead code. handle_info! was compiled into a cfunction on every parse and then never registered - readstat dropped readstat_set_info_handler long ago, and the metadata handler already sets rows and columns.

Testing

The test item now pins the readstat_alignment_t values each fixture carries. Verified the assertion is real by reverting the alignment fix: the item fails, and passes again once restored. Full suite green, and StatFiles' own suite (including its exact-string Show item) passes against this branch.

Known gaps left as follow-up issues: read_por has no test or fixture, and read_xport is exported but StatFiles never wires .xpt up.

🤖 Generated with Claude Code

[codecov-commenter]

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 83.33%. Comparing base (a0acea1) to head (dacf962).
⚠️ Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
src/ReadStat.jl	85.71%	1 Missing ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@            Coverage Diff             @@
##             main      #95      +/-   ##
==========================================
+ Coverage   79.66%   83.33%   +3.67%     
==========================================
  Files           2        2              
  Lines         177      156      -21     
==========================================
- Hits          141      130      -11     
+ Misses         36       26      -10     

Flag	Coverage Δ
unittests	83.33% <87.50%> (+3.67%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.