Skip to content

read_por is untested and has no fixture #96

Description

@davidanthoff

Found while auditing the stack (see #95).

read_por is exported and documented, but the test item only covers read_dta, read_sav, read_sas7bdat and read_xport. There is no types.por fixture in test/, so the SPSS portable reader has no coverage at all.

StatFiles does ship a test/types.por, which could be reused here, though it likewise has no test exercising it (queryverse/StatFiles.jl#32).

Worth doing alongside that: SPSS portable files exercise a genuinely different code path in readstat, and .por is the one format where the row count comes back unknown (-1), the same case read_xport hits and which handle_variable! has a special branch for.

🤖 Generated with Claude Code

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions