Raise Julia floor to 1.10 to match ReadStat - #31
Merged
Merged
Conversation
ReadStat now requires julia 1.10, because ReadStat_jll 1.1.8 and newer require at least 1.6 and anything lower silently resolves back to the December 2020 binary. Follow it here rather than leave StatFiles advertising support for julia versions its dependency will not resolve on. This mirrors commit fb42070, which set the floor to 1.3 for the same reason when ReadStat was at 1.3. The ReadStat compat bound already admits 1.2 via its "1" caret; tightening it to drop the stale 0.4.1 range waits until ReadStat 1.2.0 registers. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-on to queryverse/ReadStat.jl#95.
ReadStat is moving its julia floor to 1.10, because
ReadStat_jll1.1.8 and newer require at least julia 1.6 and anything lower silently resolves back to the December 2020 readstat binary. StatFiles should follow rather than keep advertising support for julia versions its dependency will not resolve on. This mirrors fb42070, which set the floor to 1.3 for exactly the same reason when ReadStat was at 1.3.The
ReadStatcompat bound already admits 1.2 through its"1"caret, so nothing is needed there yet; tightening it to drop the stale0.4.1range is a follow-up once ReadStat 1.2.0 registers.Testing
Both test items pass, including the
Showitem with its exact-string assertions - worth noting because that item is what would surface any drift in inferred column types. Also verified against adev-linked checkout of the ReadStat branch above, not just the registry version.🤖 Generated with Claude Code