Skip to content

fix: keep goal commands pending across execution cycles - #65

Merged
danyel117 merged 2 commits into
mainfrom
codex/goal-acp-lifetime
Oct 8, 2026
Merged

danyel117 merged 2 commits into
mainfrom
codex/goal-acp-lifetime

Conversation

@danyel117

@danyel117 danyel117 commented Oct 8, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Keep registered /goal and /resume_goal commands pending across automatic executions until the goal stops, so a compatible ACP adapter can keep the client active. Older hosts without session.wait preserve their admission behavior.

Related issue

Related to #59. Persistent plans and the separate OpenCode ACP event-consumer integration follow this slice.

Changes

  • Release the wait on cancellation, completion, limits, replacement, disabled continuation, and plugin disposal.
  • Isolate the Promise-only Effect 3 persistence runtime under the external effect-goal-state npm alias. Modern OpenCode owns Effect 4 in the SDK namespace; the bare import prevented loading. No Effect values cross the SDK boundary.

Verification

Lint, typecheck, build, npm pack dry run, 349 passing Bun tests, and native isolated ACP /goal with an automatic continuation through overall completion. No user state was used.

Checklist

  • bun run test passes (new behavior has regression coverage)
  • bun run lint passes
  • bun run typecheck passes
  • bun run build passes and dist/server.js is committed
  • README/docs updated

Merging to main automatically publishes a new patch release to npm.

Chain Context

  • Strategy: stacked PRs, each usable independently.
  • Position: 1 of 2. Base: main; starts at 8e71666.
  • Ends with: goal command lifetime and modern host runtime compatibility.
  • Dependency: none. Follow-up: persistent goal plans.
  • Review budget: 385 changed lines / 400, including generated server.
  • Rollback: revert this slice's command wait and dependency alias together.
main
 └── 📍 goal command lifetime
      └── persistent plans and ACP metadata

@danyel117
danyel117 marked this pull request as ready for review October 8, 2026 09:18
@danyel117
danyel117 merged commit 4d45479 into main Oct 8, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant