Repository navigation
feat: persist verified goal phases and ACP plan metadata - #66
Merged
Merged
Conversation
danyel117
marked this pull request as ready for review
October 8, 2026 12:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Persist the overall goal's phases, tasks, completion criteria, decisions and verification evidence. A verified task advances the saved plan while the original objective stays active; only verified overall completion closes the goal.
Related issue
Related to #59. ACP command lifetime is delivered by #65, with explicit Cancel/transport shutdown correction in #67. The host integrations are anomalyco/opencode#53913 (lifetime/Cancel) and anomalyco/opencode#53929 (live/replayed plans).
Changes
update_goal_planto V1/V2 with atomic goal-ID and revision checks, evidence requirements, bounded history, and scope-change evidence./goal edit <objective>grant to clear a planned objective. Completed work cannot disappear; modifying pending scope requires recorded evidence.Verification
Lint, typecheck, build and npm pack dry run pass. 361 Bun tests pass. Opus approved the implementation; all five PR CI checks and the release workflow passed. Native packed-package ACP tests cover two phases, automatic continuation, original-scope retention, live and reloaded plans, and cancellation during work and between cycles. Tests use isolated state and a local SSE fixture. Published npm 0.1.59 was installed exactly, gitHead 3eba062 verified, and the same native ACP scenarios passed against both pending host fixes combined: create/get goal, two phases and two continuations, five live and five reloaded plans, busy Cancel, idle Cancel, and transport shutdown preserving the goal. Combined host validation: 111 ACP tests and all 36 package typechecks pass. Native Zed UI rendering and an upstream OpenCode release remain pending maintainer integration.
Checklist
bun run lintpassesbun run typecheckpassesbun run buildpasses anddist/server.jsis committedChain Context
main; starts at fix: distinguish explicit cancellation from ACP transport shutdown #67.size:exceptionfor this slice. Opus approved the implementation and all five CI checks pass.