Repository navigation
fix: distinguish explicit cancellation from ACP transport shutdown - #67
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A Promise command abort can mean ACP transport shutdown rather than the user pressing Cancel. Preserve the goal on that generic abort and cancel it only on an explicit host interruption hook or a user execution-interrupted event.
Related issue
Related to #59 and follows #65. The companion OpenCode integration is anomalyco/opencode#53913. Opus approved the final fix; merged and published as 0.1.58 (gitHead 3b2284e).
Changes
Verification
Lint, typecheck, build and npm pack dry run pass; 350 Bun tests pass. Native isolated ACP: Cancel between cycles persists
cancelledand prevents restart, while quitting ACP and closing its standalone server preservesactive. The companion host's wire tests verify that transport close does not call the user interrupt endpoint. Exact npm 0.1.58 was installed in isolated projects through npm andopencode plugin add; config loading and native ACP creation/get_goal, full continuation, busy Cancel, idle Cancel and transport shutdown pass against the patched source host. Its release workflow passed. The upstream host release is still required for the complete ACP behavior.Checklist
bun run testpassesbun run lintpassesbun run typecheckpassesbun run buildpasses anddist/server.jsis committed