Skip to content

fix(ux): implement ten onboarding and dashboard improvements - #50

Draft
man612 wants to merge 36 commits into
mainfrom
fix/ux-audit-10-items-20261020
Draft

man612 wants to merge 36 commits into
mainfrom
fix/ux-audit-10-items-20261020

Conversation

@man612

@man612 man612 commented Oct 20, 2026 •

Copy link
Copy Markdown
Owner

Implements all 10 UX requirements tracked in #48 on a dedicated review branch, without changing Gnirehtet/ADB service logic, genuine RX/TX counters, or dependency versions.

Changes

  • UX-01: live Dark/Light preview during onboarding.
  • UX-02: compact diagnostics with a 2.6-second reveal after actual scan completion, manual disclosure override.
  • UX-03: native Electron clipboard IPC with progress, success and visible failure messaging; masked device IDs.
  • UX-04: real diagnostics rerun, automatic expansion, busy/completion/error feedback, conditional auto-collapse.
  • UX-05: structured device details, clean encoding, localized timestamps with seconds.
  • UX-06: responsive Android cards at narrow sizes, with per-device controls, genuine counters and battery; no forced horizontal table scrolling.
  • UX-07: disabled Clear button when the log is empty.
  • UX-08: compact dismissible ready-state notice.
  • UX-09: persisted timestamp of actual update check attempts/success, localized to ID/EN.
  • UX-10: terminal-only autoscroll without dragging the dashboard to its log.
  • Follow-up: prevent stale diagnostic success after a failed retry; run initial diagnostics for returning users; fix an additional 600px Engine header text-squeezing defect.

Verification completed (2026-10-21)

  • Windows local npm ci, typecheck, production build and Electron Builder unpacked package smoke (npm run package:check): PASS.
  • Lint: 0 errors, 231 existing formatter/hook warnings (not a clean warning-free run).
  • Vitest: 52/52 PASS.
  • Live Chromium renderer interaction with synthetic Electron API/Android data: 18/18 PASS, including real React effects/timers, Dark→Light→Dark, failed/recovered rerun, clipboard error, empty and two-device states, last update timestamp persistence, per-device start/stop/retry with localized visible failure and recovery, log scroll position and layout at 600 / 800 / 1008 / 1280 px.
  • Reproducible optional browser harness (no dependency changes): scripts/qa/renderer-mock-qa.cjs.
  • Detailed test matrix · 1008px collapsed dashboard · 600px two-device state · onboarding Dark / Light.

All QA screenshots contain fabricated device names/IDs; no real handset identifiers are uploaded.

Still to verify (not claimed to pass)

  • Cold-start investigation Investigate intermittent blank renderer on local Windows Electron preview #44 remains OPEN: three earlier isolated unpacked Electron launches rendered correctly, but latest isolated debug-port probes failed to expose a CDP endpoint while the executable was alive. This does not prove a blank renderer or constitute a cold-start pass. Detailed investigation is still needed, including installed NSIS launches without debugging.
  • One real Android handset's USB/VPN connect → disconnect → retry → stop and true TUN traffic in a build containing these latest UI commits. Prior hardware testing is documented in Track v1.2 real-device validation and release readiness #38 but is not a fresh hardware retest of this branch.
  • Native Windows display scale/keyboard/a11y spot checks, as feasible. The Chromium UI tests do not substitute for physical hardware tests.

GitHub Actions account usage limits must not be confused with code failures; local validation is recorded independently. No dependency modernization or public release is part of this PR. Keep the PR open for final review rather than implying the shipped app or the physical phone has already passed the newest build. Closes #48 only when merged after review.

Follow-up UX QA commit: 393623b adds separate in-flight locks and localized visible errors for per-device actions. Latest local checks: 18/18 interactive browser scenarios, 52/52 Vitest cases, packaging pass; lint 0 errors with 231 warnings. No dependency upgrades.

man612 added 23 commits October 20, 2026 21:01

man612 commented Oct 20, 2026

Copy link
Copy Markdown
Owner Author

Hasil validasi otomatis — 20 Oktober 2026

CI Windows terbaru lulus seluruh tahap pada commit 26dd580: run #85.

  • Dependency installation, release metadata, runtime pin checks, pinned runtime preparation: passed.
  • ESLint lint: passed (non-blocking Prettier warnings remain, as also seen in existing files).
  • TypeScript node + renderer: passed.
  • Vitest unit tests, including new UX checks: passed.
  • Electron renderer/main build: passed.
  • Windows package smoke and size/locale reporting: passed.

Belum diverifikasi: visual/interaction QA pada jendela 1008×650, 800×600, 1280×720, Dark/Light dan ID/EN; clipboard native di Windows nyata; auto-collapse manual override; scrolling terminal ketika ada banyak log; dan satu perangkat fisik saat connect/disconnect/retry. Komputer lokal Windows sedang offline. Tidak ada klaim seluruh perilaku UI/hardware sudah teruji. Tetap draft, jangan merge atau close #48 sebelum QA ini selesai.

man612 commented Oct 24, 2026

Copy link
Copy Markdown
Owner Author

2026-10-24 GitHub-only UX audit — Windows host offline

Audited all ten requirements in issue #48 against actual PR #50 source. The ten features are present in source, supported by the previously recorded 18/18 synthetic Chromium mock and 52/52 local Vitest evidence on historical head 393623b. Those older passes do not validate today's new changes. Full matrix and handoff: docs/qa/UX_OFFLINE_SOURCE_AUDIT_2026-10-24.md.

Found an actual UX logic gap: a diagnostics API run can succeed but return an individual check with status:'error' (e.g. missing ADB runtime); the old 2.6s timer auto-collapsed this important failed check. Now the panel retains visibility in that case while allowing the user to collapse it manually. The rerun status distinguishes an execution failure from a completed scan with check issues.

Changes in isolated PR #50 branch: a small pure helper + three unit test cases, limited Dashboard.tsx disclosure/feedback logic, ID/EN localized warning, one new future Chromium mock regression scenario, and agent/QA handoff documentation. Baseline 393623b -> latest daf7c6b: 8 commits, 7 changed files, all UX/docs/QA; no ADB/Gnirehtet runtime, startup PR #51, Tauri PR #52, installer, dependency, or main changes.

Checks actually performed offline: 10/10 static/pure-JavaScript logic assertions passed using fetched source (not native repo tests); optional browser QA harness parsed as JavaScript. NOT EXECUTED on new head: native Vitest, typecheck, build, browser UI mock, Windows installer/NSIS, actual clipboard/keyboard/display scaling, and real Motorola USB/VPN/TUN counters. Newly added browser case expects 4/6 passing checks after one synthetic ADB check fails, and must be executed after the Windows machine is available.

Keep PR #50 DRAFT and issue #48 OPEN. Do not merge/release or claim physical-device parity. Windows access is planned roughly Tue 2026-10-27 09:00 WIB but is not guaranteed. Source and actual QA results supersede this dated note.

man612 commented Oct 24, 2026

Copy link
Copy Markdown
Owner Author

2026-10-24 cross-PR integration audit (GitHub-only; no merge)

Compared PR #50 daf7c6b, PR #51 a0b2aa5, and main 188751e. Exactly three changed-file paths overlap: src/main/ipc.ts, src/renderer/src/App.tsx, AGENTS.md. Each PR is individually mergeable against main, but this does not verify their combined tree or functional behavior.

P0 risk #1 — IPC: PR #51 adds asynchronous getServices()/trustedServices() readiness gating and sender revalidation. PR #50 adds app:copy-support-report backed by Electron's clipboard + preload type/renderer UI. Selecting either file wholesale can break one feature or the startup security/lifecycle safeguards.

P0 risk #2 — React App: preserve PR #51's renderer marks + lazy Settings and PR #50's language prop to Dashboard and theme effect guard settings.onboardingCompleted. Otherwise onboarding Light preview can be overwritten, locales broken, or startup milestones lost.

P1 risk #3 — agent notes: retain both independent QA handoffs in AGENTS.md.

Full source-grounded preservation plan and target verification gates: https://github.com/man612/wirebound/blob/fix/ux-audit-10-items-20261020/docs/qa/PR50_PR51_INTEGRATION_CONTRACT_2026-10-24.md

Status: Documentation only in PR #50 branch; no cross-branch merge/rebase, production source edit, Node/Windows/browser test, NSIS build, or USB test was carried out. Keep #50/#51 Draft, #44/#48 Open. The planned Tue Oct 27 Windows restart is not confirmed availability.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

UX overhaul: 10 hands-on onboarding/dashboard issues in v1.2.0

1 participant