Skip to content

fix(adb): mask serials in warnings and count successful client stops (#56) - #57

Merged
man612 merged 4 commits into
mainfrom
fix/issue56-adb-log-privacy-cleanup-20261024
Oct 28, 2026
Merged

man612 merged 4 commits into
mainfrom
fix/issue56-adb-log-privacy-cleanup-20261024

Conversation

@man612

@man612 man612 commented Oct 24, 2026

Copy link
Copy Markdown
Owner

Follow-up to issue #56, isolated from lifecycle remediation PR #55.

Production change is confined to src/main/services/adbService.ts. Three ADB console warnings (device-detail query, failed force-stop, and failed Gnirehtet reverse cleanup) now use a masked device ID and replace that ID inside their error messages. stopClient() returns whether the force-stop command succeeded; stopAllClients() counts acknowledged successful commands, rather than all previously active clients. Gnirehtet-specific reverse cleanup remains best-effort and independent. The source does not touch global ADB, executables, engine process lifecycle, settings or dependencies.

New tests: two native Vitest fixtures written with fake device IDs to check partial force-stop failure, two device attempts, targeted reverse cleanup, warnings without full IDs, and failed device-details fallback.

Actual offline verification: real, freshly fetched function/method bodies of the updated source were exercised with a synthetic ADB executor and console logger; 7/7 isolated JavaScript assertions passed (one successful stop out of two, both warning IDs masked). These are NOT native Vitest/typecheck/build results. A separate Linux scratch container had Node 22, but could not resolve github.com to obtain the repository, so native tests could not run there. Windows and Android remain offline. Do not promote the 7/7 to native QA.

Limitations: a successful ADB am force-stop command is not proof that the Android VPN physically ended. The three warnings are not a universal sanitizer: raw Gnirehtet stdout/stderr and other IPC/service errors need an independent privacy review. Do not claim complete privacy hardening, merged integration, or release-ready status.

Detailed QA checkpoint and agent handoff

DRAFT: DO NOT MERGE until running exact-branch native typecheck, focused/full Vitest, build, then isolated Windows QA and a single-real-phone USB/ADB/VPN parity check. Preserve issue #53 lifecycle fix in separate PR #55, startup #51, UX #50, Tauri #52, and main. No dependency upgrades, Windows installation, global ADB process action, or release occurred.

man612 commented Oct 24, 2026

Copy link
Copy Markdown
Owner Author

Separate privacy scope note: Draft PR #59 handles GnirehtetService native process stdout/stderr and its own returned errors, whereas this PR #57 masks device-specific warnings in AdbService and corrects force-stop success counts. Neither is comprehensive PII removal; do not infer raw terminal logs are exported by Copy Support Report. Keep both branches independent until native tests, Windows QA and authorized integration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant