Repository navigation
fix(adb): mask serials in warnings and count successful client stops (#56) - #57
Merged
Merged
Conversation
This was referenced Oct 24, 2026
Owner
Author
|
Separate privacy scope note: Draft PR #59 handles GnirehtetService native process stdout/stderr and its own returned errors, whereas this PR #57 masks device-specific warnings in |
man612
marked this pull request as ready for review
October 28, 2026 02:43
This was referenced Oct 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to issue #56, isolated from lifecycle remediation PR #55.
Production change is confined to
src/main/services/adbService.ts. Three ADB console warnings (device-detail query, failed force-stop, and failed Gnirehtet reverse cleanup) now use a masked device ID and replace that ID inside their error messages.stopClient()returns whether the force-stop command succeeded;stopAllClients()counts acknowledged successful commands, rather than all previously active clients. Gnirehtet-specific reverse cleanup remains best-effort and independent. The source does not touch global ADB, executables, engine process lifecycle, settings or dependencies.New tests: two native Vitest fixtures written with fake device IDs to check partial force-stop failure, two device attempts, targeted reverse cleanup, warnings without full IDs, and failed device-details fallback.
Actual offline verification: real, freshly fetched function/method bodies of the updated source were exercised with a synthetic ADB executor and console logger; 7/7 isolated JavaScript assertions passed (one successful stop out of two, both warning IDs masked). These are NOT native Vitest/typecheck/build results. A separate Linux scratch container had Node 22, but could not resolve github.com to obtain the repository, so native tests could not run there. Windows and Android remain offline. Do not promote the 7/7 to native QA.
Limitations: a successful ADB
am force-stopcommand is not proof that the Android VPN physically ended. The three warnings are not a universal sanitizer: raw Gnirehtet stdout/stderr and other IPC/service errors need an independent privacy review. Do not claim complete privacy hardening, merged integration, or release-ready status.Detailed QA checkpoint and agent handoff
DRAFT: DO NOT MERGE until running exact-branch native typecheck, focused/full Vitest, build, then isolated Windows QA and a single-real-phone USB/ADB/VPN parity check. Preserve issue #53 lifecycle fix in separate PR #55, startup #51, UX #50, Tauri #52, and main. No dependency upgrades, Windows installation, global ADB process action, or release occurred.