Skip to content

docs(qa): Gnirehtet lifecycle race audit and regression contract (#53) - #54

Closed
man612 wants to merge 2 commits into
mainfrom
docs/issue53-lifecycle-safety-audit-20261024
Closed

man612 wants to merge 2 commits into
mainfrom
docs/issue53-lifecycle-safety-audit-20261024

Conversation

@man612

@man612 man612 commented Oct 24, 2026

Copy link
Copy Markdown
Owner

Documentation-only safety audit for issue #53, performed while the maintainer's Windows QA machine is intentionally offline.

Source evidence: the current gnirehtetService.ts blob (6b6fc11d) is identical on main, UX PR #50 and startup PR #51. Isolated JavaScript evaluation of original source method bodies with mock ADB/processes reproduced:

  • Two Starts waiting for ADB -> two child spawns, only second tracked.
  • Stop before pending Start resumes -> Stop returns success, then a child is created while service reports disconnected.
  • Late close after simulated 2s Stop timeout -> old child dispatches unexpected-exit cleanup.

Documentation also flags possible raw device ID leakage in console logs and potentially misleading cleanup counts. These are source audit findings; no native Electron, Node/Vitest, official installer, Windows process or physical Android test ran in this session.

Files: lifecycle safety audit and an AGENTS.md handoff pointer. No src/, package.json, dependencies, release, QA instrumentation, PR #50/#51 or main changes.

DRAFT / hold for a separate regression-first production fix and Windows+single-phone validation. Do not merge this just to claim the lifecycle is safe. AGENTS.md may conflict with PR #50/#51's independent agent notes; when any integration is eventually approved, preserve all handoff sections.

man612 commented Oct 24, 2026

Copy link
Copy Markdown
Owner Author

Follow-up remediation now proposed separately in Draft PR #55. The original audit in #54 remains documentation-only and unmerged. Updated source method bodies passed 5/5 isolated fake-process control-flow scenarios, but native Vitest, typecheck, Windows process lifecycle, and real Android testing are not done. Review the issue #53 fix checkpoint; do not treat this as release approval.

man612 commented Oct 28, 2026

Copy link
Copy Markdown
Owner Author

Superseded safely by merged PR #61. The original #54 encountered a real AGENTS.md conflict after the ADB privacy PR #57 was merged. PR #61 reconstructed the same lifecycle QA document against current main, preserved both issue #53 and issue #56 agent handoff sections, passed hosted Windows CI (lint, typecheck, unit tests, build, package smoke), and was squash-merged as 64813d1db51ba319fed15086e1d9b25758545ea0. Verified the current main contains both sections and the exact audit document. Closing #54 unmerged as redundant, not deleting the branch or closing issue #53. No Gnirehtet runtime fix or hardware QA is implied.

@man612 man612 closed this Oct 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant