Skip to content

Load the matching framework by default during native20 crossings - #411

Draft
shiny-code-app[bot] wants to merge 1 commit into
work/opw314-actions-1107from
work/opw314-framework-default-1108
Draft

shiny-code-app[bot] wants to merge 1 commit into
work/opw314-actions-1107from
work/opw314-framework-default-1108

Conversation

@shiny-code-app

@shiny-code-app shiny-code-app Bot commented Nov 8, 2026

Copy link
Copy Markdown
Contributor

Native20 OpenUpgrade crossings currently default to base,web, even when the artifact contains the matching20 framework. Default the crossing to base,web,openupgrade_framework and reject a19 manifest before execution. Explicit opt-out remains available for a separate validation pass; ordinary addon maintenance keeps its existing selection.

Closes #410 . Stacked on #407 ; this change does not edit that source branch or the existing source stack. Required by https://github.com/cbusillo/odoo-tenant-opw/issues/314 and adopted review https://github.com/cbusillo/odoo-tenant-opw/issues/471#issuecomment-6685404577 .

Validation:134 workflow tests pass; the default-load regression fails against the previous implementation. Ruff passes. Native PyCharm completed with UNKNOWN because the Pydantic support plugin was unavailable. Matching tenant consumer Build will be attached when earned.

Removed: native20 crossing default that silently skipped the matching framework. Net lines: +5 (19 added,14 removed).

@shiny-code-app

shiny-code-app Bot commented Nov 8, 2026

Copy link
Copy Markdown
Contributor Author

Read and adopted the source-backed Fable findings at https://github.com/cbusillo/odoo-tenant-opw/issues/471#issuecomment-6685404577 . New source: matching20 framework default/pin, bank/UOM rename pre-script, native module merges instead of nine removals, saved19 database-only diagnostic alias/no full-store output/scans, and one complete framework-free active-view validation. The existing fatal unsafe-deletion guard remains byte-identical.

Controls:134 shared workflow tests;121 script tests (7existing skips);602native addon tests,0failure/0error. The old workflow fails the framework-default regression; old attachment code fails the database-only no-payload-read regression. Nondefault bank/UOM fixtures and conflicting-target/no-mutation control pass. Native merged modules stay installed; ordinary retirement and unused-descriptor deletion controls still pass.

A bounded Google implementation review of the new composition was attempted through the ordinary helper; the selected agy-gemini account returned ERROR after600seconds and produced no review. This is not a completed implementation review, and no alternate-provider retry or approval is inferred. The supplied Fable review remains the source-plan review being adopted. PyCharm remains UNKNOWN: tenant dependency-revision mismatch; shared Pydantic plugin unavailable. These limitations are retained, not passes. No source landing or testing migration result follows from the checks.

Removed: automatic base,web-only20 crossing; nine merged modules from Enterprise retirement; full application payload scans and filestore copy-out on database-only diagnostics. The supported original/overlay integrity guard still hashes its retained lower; that protection is not waived.
Net lines: OPW+279; shared devkit+5 (final source accounting will be corrected if a later delta changes it).

@shiny-code-app

shiny-code-app Bot commented Nov 9, 2026

Copy link
Copy Markdown
Contributor Author

Matching consumer source capability is now earned: OPW4a71a34ed73576e0a2e5a857813f687ffe7cce3e Build42647834936 succeeded, immutable image ghcr.io/cbusillo/odoo-tenant-opw@sha256:ce70354f472e93592d910bdc2fd61eb7c133c7d7e22c9525ac12f607da6df74f. Its downloaded manifest SHA256483068d29fe3c23bada58282cae745a134d1f5c935bbfa7d2a79cfaa6d398fe2 records build_tools/odoo-devkit at exact1dd946511dc5c0b67101ebbd69447700134b4c33; tracked workspace pins agree. Artifact checks find upstream20 framework229928f995bab5081b0b53810ffa1078d62f8f8f; library46d66ff5ed6a99481f84d3c79fc6e50835da7286.608native addon tests and native SQL18/19/20 qualifications passed in that Build.

Fresh source411 checks remain4green at1dd; no new test/CI/review run, source edit, readiness/landing or runtime install claimed here. This is Build/input capability, not a migrated database. Actual full028 stopped during input transport before Odoo, collected143cleanuptrue; migration/testing completion remains unearned.

@shiny-code-app

Copy link
Copy Markdown
Contributor Author

Hold on the 403/405/407 stack, read from the train's pass at 11:34 AM ET.

405's own stop is fixed. The train no longer reports failing checks or missing notes on 405, and 403, 405 and 407 each have checked Ready on their current heads (0fcf6f0, 346328b, bc3bb03).

The stack still cannot land. Draft #411 is stacked on 407, and the train collapses every stacked child into the root. 403 is therefore blocked with stack_unsupported: #411 is a draft and has no ready-to-merge label. 411 is issue 410's released source, and it is outside this finisher's assignment.

Next actor: agent:supervisor-milestone, the recorded next actor on #410 , through the Odoo lead. Choose one:

  • The documented stacked-PR route: retarget held draft 411 to main and leave it draft. The train then lands 403/405/407, and 411 continues on its own.
  • Finish 411's proof and Client test notes, then mark it checked Ready so the whole stack lands together.

Never ready or label 411 just to unblock its parents. No base, branch or source here was changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants