Repository navigation
Stage stock HR preferences before native20 parent-view validation #367
Description
Objective
Fix the demonstrated stock HR preference-view loading-order failure in the existing guarded native20 preparation. Program parent: #277 ; actual affected copy: https://github.com/cbusillo/odoo-tenant-cm-website/issues/273 ; admission: https://github.com/cbusillo/direction/issues/4 .
Evidence and scope
The complete frozen e89/4d1 website batch has finished both original jobs with cleanup_complete=true. The actual-copy job passes source/image/input/fence admission, all35 strict column checks, a fresh native20 reference, and independent business/projection/file/core preservation diagnostics. Its ONE fatal loader traceback is native hr/views/res_users.xml:9: writing parent hr.res_users_view_form_simple_modif validates old child hr.res_users_view_form_preferences before that child's new XML loads. Its old h5_email XPath no longer exists in the new parent. Final conversion/UI/pages remain unqualified;145 partial registry findings are crossing fallout, not145 independent bugs. The independent synthetic job surfaced only two fixture errors, now corrected separately on the website task branch; no rerun has occurred.
Root independently qualifies the original HR parent/current child AND saved previous architectures as exact stock19 through existing comment/text/attribute-preserving _normalized_architecture, using official19 commit a789a218. Both are active, en_US-only, arch_updatedfalse, sole correct non-noupdate aliases, no groups/customizations. The full observed branch has parent1132, child1134, retiring hr_homeworking1435 and surviving mail_bot_hr1494/1495. Their identities/topology must survive; do not infer that a parent has no children. Original base173 branch and ordinary HR users-form sibling were also screened; ordinary sibling is not stock-qualified for a change and is not a second demonstrated failure.
The current target native loader/view filter admits same-module retained descendants while updating the HR parent; the clean native20 reference succeeds. Public target cohort includes ten manifest-loaded preference declarations. The observed defect is core HR's stock19 child, distinct from completed Calendar332, public hierarchy336, and344's delivered old hr_org_chart action/link changes. No old hr_org_chart preference alias exists in this actual website copy. Full332/336/344 discussions and owner-wide open/closed exact/family searches were read; those deliveries stay closed and are linked context, rather than broadening their source finish lines.
Finish Line
Deliver the smallest reviewed shared correction for this demonstrated load-order conflict, reusing existing native/shared preparation primitives. Preserve IDs, native ownership/UI, user/preferences data, references, attribution/history/security and custom/translated/protected/dependent states, or refuse an unqualified actual shape before effects. Keep all planning/admission before any bridge effects. No generic view-rebase engine, family deletion/deactivation, validation waiver, guessed old stock/default or replacement feature. Distinguish the ordinary sibling source screen from an admitted change. Root owns final current-head CI/consumer/train delivery, candidate adoption and one next combined native/data batch; source delivery alone proves no migration/UI/Client result.
Delegated Technical Inputs
Root-screened packet: /Volumes/Developer-Artifacts/task-evidence/odoo-devkit/odoo20lead4-1101/hr-preferences-screened-source-packet-1103/ . source-shape-predicates.json SHA25668ca3ad89d9eda272d8fccf0c9fea03ee83bea2fa6d989a67b8b73daa5025a9a . It contains public stock XML and value-free root predicates only. Exact target20 PUBLIC source/hash/manifest/loader receipts: ../web273-batch-failure-diagnosis-1103/history255/ . Original SQL/profiles/q/architectures/business/audit/credential siblings are NOT delegated. Missing precise source predicates return to root; do not fill them from defaults. Source19/18 is static only.
Current Status
Next actor: agent:supervisor-milestone
Next action: Verify the full account-succession handoff and exact claim audit at https://github.com/cbusillo/odoo-tenant-opw/issues/314#issuecomment-6817852660 before arranging non-overlapping codex-chris succession. Preserve retained source trees/PRs, original keys and qualified run030 inputs; successor source delivery uses the existing reviewed evidence and normal claim route. No source, runtime or cleanup operation is assigned by this status edit.
The actual OPW18→19→20 attempt reproduced a false custom-history stop: the active views match stock19, while the HR primary and MailBot preference child retain exact stock18 histories. Their definitions were matched to pinned official18 source. Source397 at b258d57 accepts those two histories only on their own records and preserves them; custom/translated/protected/dependent checks still precede effects. The original error reproduces before the fix and passes afterward.
All87 affected HR/core tests, Ruff and formatting pass. Independent Anthropic claude-opus-5-5 review found no blocking defect; its wrong-record coverage suggestion was added and passes. Both exact-head tenant consumer builds pass with retained runtime/source/platform evidence. Native inspection is UNKNOWN: native_python_support_plugin_unavailable, Pydantic support plugin unavailable, no coverage and cleanup closed; the recorded temporary Director allowance applies, with no unchanged retry or configuration change.
The actual20 retry continues separately from the unchanged completed19 pair on cbusillo/odoo-tenant-opw#314. This source fix does not establish a migrated20 database or testing restore. Original data and evidence remain retained.
Removed: false rejection of two stock18 saved view histories. Net lines: +83.
Account succession and retained work: https://github.com/cbusillo/odoo-tenant-opw/issues/314#issuecomment-6817852660 . Source branches/worktrees and frozen inputs are intentionally retained; no ledger transfer, operator launch, runtime read, cleanup or checkout refresh occurred.
Activity
shiny-code-app commentedon Nov 3, 2026
Claimed by ODOO20LEAD4-1101
Session: 01a199ca-e013-7c52-8f48-d31dd51ec523
Branch: work/odoo20lead4-hr-prefs-1103
Claimed at: 2026-11-02T23:34:18-05:00
Next action: Implement the now-root-qualified stock HR preference loading-order correction through one in-harness editor in a configured task worktree; source-only guarded proof, review and normal combined delivery, preserving all original/canonical/data/Client/QA holds.
Admission: milestone; https://github.com/cbusillo/direction/issues/4
Work record
shiny-code-app commentedon Nov 3, 2026
Released claim 6595540222
Next actor: agent:supervisor
Next action: consume the checked current-head Ready on #368 and route its normal merge-train landing. Source implementation is complete; no new implementation worker. Root programme 277 retains exact landing readback, paired tenant adoption/artifact qualification and the next affected-input actual-copy batch.
Source PR at 5bc893a is clean/bot-pushed and Ready. All 7 current-head checks pass with complete job evidence. Required OPW and website production consumer checks pass at the exact candidate/tenant main refs and linux/amd64, with retained archive digests and dependency evidence qualified. Own weighed strongest 5.5 review and final isolated Python inspection are current: complete 3-file coverage, 0 introduced actionable findings; 7 preexisting findings and 1 genuine XPath spelling advisory remain explicit. 109 complete affected safety cases, lint/format, both offline locks and package build pass. Full-history pre-handoff radar is clear. PR notes now explicitly classify this shared preparation source as engineering; no Client acceptance is requested or transferred.
The exact affected stock HR child stages genuine native 20 architecture before parent reload; all current/previous/source/topology/security predicates run before effects. Preparation preserves parent, descendants, IDs/aliases/scalars/history. Native later history writes remain native behavior, not an end-to-end arch_prev promise. No empty XML, new journal/posthook/framework or validation waiver. No native/heavy/data run occurred in this source slice. Completed source issues332/336/344 stay closed; website273 remains actual conversion/fixture/page qualification.
Retain the clean external task tree /Volumes/Developer-Artifacts/worktrees/odoo-devkit/odoo20lead4-hr-prefs-1103 and source/evidence under the recorded programme custody until landing/adoption/actual-data qualification finish. Root programme 277 retains every original/backup/lower/profile, product canonical branch, operator, Client and sole QA hold. Do not remove retained trees or replay prior failed originals. Q1096 remains complete; Q1097 retains light source work until final data qualification.
Removed: obsolete stock HR selector failure through the existing preparation; reused its XML reader. Net lines:+631 (129 production +262 exact public-stock fixtures +217 behavioral tests +23 docs), supplying finite stock proof and preservation/refusal coverage without another tool/step.
Source claim6595540222 is ready for exact authored release; root277 continues programme custody rather than duplicating this source claim. No whole migration/UI/Client/production pass is claimed.
Session: 01a199ca-e013-7c52-8f48-d31dd51ec523
Retained PR handoff: #368
shiny-code-app commentedon Nov 3, 2026
Final landing evidence: the shared HR preference fix is train-landed at4199720d5f78c3678371463d760f8c6119109ccf. Post-landing native checks are now complete/success for both19.0 and20.0, alongside the already-green landing CI/CodeQL, exact-head consumer checks and source review/inspection. The primary checkout remains independently reconciled to the landing. This issue stays closed and its exact claim release remains in place; actual copied-data/native/page proof continues on the existing conversion child, with the later distinct HR type failure owned by source369.
Removed: no further source change. Net lines:0 in this final evidence update; the completing change retains its recorded source accounting.
shiny-code-app commentedon Nov 6, 2026
Reopened for the reproduced OPW backup run in cbusillo/odoo-tenant-opw#314. Native 20 stopped at
Preserve customized HR preferences historyafter the complete 18→19 migration and verified 19 handoff. The actual 19 HR cohort has older saved view histories and a different factory child shape than the existing snapshot. Compare the exact shipped definitions, fix the shared migration, and preserve customized/history/dependent states. The clean 19 pair and failed-run evidence remain retained.shiny-code-app commentedon Nov 7, 2026
Correction to the reopen note: all four active HR/mail-bot preference views match the exact shipped 19 definitions and the existing stock snapshot. My first comparison dropped XML comments and falsely reported a different child shape. The reproduced failure is limited to older saved histories on the HR primary and mail-bot child views. Comparing those histories with the shipped 18 definitions before changing the shared guard.
shiny-code-app commentedon Nov 7, 2026
Claimed by OPW314-EXECUTE-ASTRA-1106
Session: 01a1af86-fed7-7980-8b79-f8b78d3104c1
Branch: work/opw314-hr-history-1106
Claimed at: 2026-11-06T19:00:36-05:00
Next action: Repair the reproduced native20 HR preference history failure from the actual completed OPW19 copy; preserve custom history and retry unchanged19 through the normal heavy path.
Admission: milestone; https://github.com/cbusillo/direction/issues/4
Work record
shiny-code-app commentedon Nov 12, 2026
Released claim 6699120591
Next actor: agent:supervisor-milestone
Full current operational/source handoff: https://github.com/cbusillo/odoo-tenant-opw/issues/314#issuecomment-6817852660 . Source native 01a1af86-fed7-7980-8b79-f8b78d3104c1, existing OPW314-EXECUTE-ASTRA-1106/codex-info; account-capacity succession is to codex-chris only after Supervisor verifies final audit and guarded non-overlap. This exact claim releases source ownership only. Preserve branch work/opw314-hr-history-1106, every referenced tree/commit, all originals/keys/qualified run030 pair/archive and unknown-effect/production safeguards. No source/data/credential/ledger/account mutation or new operation is authorised.
The real testing original034214Z-d98e830f068b6221 is terminal pass at2:18:53AMET November12; canonical result https://github.com/cbusillo/odoo-tenant-opw/issues/314#issuecomment-6817585690 . No active observer/job/copy/controller is owned by this source. Existing source checks/reviews/inspection limits remain on their exact records; no new qualification is claimed. Do not resume historical PIDs/closed workers.
Retained source stack, same source native: #403 at0fcf6f0e658f0f7aaee478d789656b2594bc3019; #405 at346328bae8d791f1de714cdd23f7bd0757894c77; #407 atbc3bb0391dcf044bf0bddb99dee55d7ad9fab538; #411 DRAFT at1dd946511dc5c0b67101ebbd69447700134b4c33. Preserve current bases and existing current-head Ready/review/CI receipts; normal delivery/proof remains with Supervisor/generation9, not an old metadata native. No rebase/retarget/source edits/Ready refresh or data rerun here.
Other retained status follow-through: cbusillo/codex-skills#3979, https://github.com/cbusillo/odoo-tenant-opw/issues/345, https://github.com/cbusillo/shiny-infra-ops/issues/746. These preserve source adoption/current-copy outcome/history, not additional data authority. No cleanup/pruning; full claim audit after exact releases will be posted to314/277. Same source session stays at prompt until Supervisor verifies closure.
Session: 01a1af86-fed7-7980-8b79-f8b78d3104c1