Repository navigation
Design B, Phase 1: top row, timer card, Look & sound sheets (behind new_look) - #154
Draft
ShuhaoZQGG wants to merge 6 commits into
Draft
ShuhaoZQGG wants to merge 6 commits into
ShuhaoZQGG wants to merge 6 commits into
Conversation
…; TUTORIALS_URL VideoPreviewLayer takes revealControls='hover' (design B) to keep − / + / eye / reset out of sight until the chip or badge is pointed at or focused, and a chipHint under the chip. Today's panel keeps 'always'. useLiveTimer also returns cardImagesGeneration, so a view can follow the artwork.
…nu, no footer Agenda / Timer / Report as a segmented switch (PostHog ids unchanged), the Pro chip where the footer's Upgrade button was (locked 'coming soon' while pro is off, the launch dot once it is on), and the ⋯ menu: your plan and the club code (pro only), roles & timing rules, clear the timer from my video, how-to videos, feedback, rate the app. Behind new_look.
The card takes the meeting's colour: speaker and role pickers, the rules line, a 16:9 preview with the count-up chip and club badge (controls on hover), the clock and one status line, preview swatches, and the buttons for ready, running, paused and video off. Up next, the after-Finish note for a row that needs a role, break length with Stop music, and custom times in one row.
TimerTab draws the card from useLiveTimer, so every push to Zoom is the old tab's code. Look & sound rows show their current values and each opens only its own sheet: On your video (modes, clear), Cards (sets only), Sounds (the same lock), Between speeches (timer card, or my video with an optional background).
This was referenced Nov 15, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Plan 13, Phase 1 of design B: the new panel's shell and Timer tab. Stacked on #153 (Phase 0);
this PR's base is that branch, so the diff is Phase 1 only. It retargets to
devwhen #153 merges.Why
The approved design B boards: BTop, BCard, BLook, B-T01–T15, B-L01–L07 and B-P01. The timer becomes
the centre of the panel, settings move into sheets, and the footer's buttons move into the top bar.
What changes
Only with
new_lookon (off everywhere today):tab_viewedids unchanged),the Pro chip and ⋯. No footer.
prois off it is locked and listswhat is coming. Once
prois on it opens Upgrade, with the launch dot for free plans and amberfor Pro.
prois on), Roles & timing rules,Clear the timer from my video (works from any tab: it switches to Timer first), How-to videos
(toastmusters.com/tutorials), Send feedback, Rate the app.
speaker. A row that needs a role is marked and still refused.
controls now show on hover or keyboard focus. A one-time "Drag me to move…" hint.
6:00", …), the preview swatches, and Start + Reset / Stop + Finish / Continue + Reset + Finish.
role, the video-off notice, break length (10/5/3/Custom) with a new Stop music button while
break music plays, and custom times in one row.
own-background picker under My video.
useLiveTimer, Phase 0's lift of LiveTab'slogic. The new tab adds no video code. Components live in
apps/zoom-app/src/b/.VideoPreviewLayergainedrevealControls="hover"and a hint; today's panel keeps the oldbehaviour.
Design calls the boards left open:
background" while an image was saved would have had to delete the image.
Phase 2's sheet, and the stage still uses today's TimerStage until Phase 3.
Security
None. No routes, no data changes.
Production impact
None while
new_lookis off. Rollback is a revert.Testing
npm test: 128 files, 2420 tests pass. New:TopBar.test.jsx,TimerCard.test.jsx,NewLookShell.test.jsx(each row opens one sheet, Timer-only toast, between-speeches choice, clear from ⋯ on another tab, the
after-Finish note),
format.test.js.npm run test:e2e: 64 passed, includinge2e/zoom.new-look.spec.js(fits 360 and 400 px with nosideways scroll and one top row, Start above 560 px, a full speech into the report, every sheet, hover
reveal, the ⋯ menu with Pro on).
npm run test:specs: 14 valid, no drift.paused states, both sheets.
Evidence (real Zoom client)
Held on purpose: the Zoom-client runs happen once, after plan 13's last phase, as asked.
Not verified
e2e/zoom-client/new-look.md: NL-01 to NL-12, not run.new_lookoff:timer-core,timer-sounds,club-card-sets,zoom-deeplink(doc note only).All are held until the last phase. Old specs now say to deploy
FLAGS_FORCE "1,new_look=0".Look here first
apps/zoom-app/src/b/TimerTab.jsx: the wiring touseLiveTimer, the ⋯ clear request, the after-Finish note.apps/zoom-app/src/components/VideoPreviewLayer.jsx: hover reveal (shared with today's panel).apps/zoom-app/src/b/LookSheets.jsxBetweenSheet: the between-speeches model.