Repository navigation
Design B, Phase 3: Pro sheets, launch card, notices, stage, rollout (behind new_look) - #156
Draft
ShuhaoZQGG wants to merge 3 commits into
Draft
ShuhaoZQGG wants to merge 3 commits into
ShuhaoZQGG wants to merge 3 commits into
Conversation
… stage label A LookContext tells shared dialogs they are inside design B's shell: Upgrade and the club question open as sheets, the Pro launch window becomes the card with the four timing cards (same words), and the stage's share button reads 'Share to the meeting'. Outside the new look nothing changes.
…ro is coming The pre-launch notice promises a new look; once new_look is on for someone, it says where things went instead and keeps Pro as what is coming.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Plan 13, Phase 3, the last phase of design B: Pro, notices, the stage, and the rollout.
Stacked on #155 (Phase 2, on #154 and #153); the diff is Phase 3 only.
Why
The approved boards B-P02–P04 (Pro and the launch window), B-N01–N03 (notices) and B-T16 (stage).
With this, every design B board is built behind
new_look.What changes
Only inside design B's shell:
LookContext: NewLookShell provides'b', so dialogs that both panels open can presentthemselves the new way. Everywhere else they are unchanged.
is the same component.
(the pro-launch spec's copy still holds) and the same trigger, 2.5 s after a Finish.
matched the board.
now, with your settings under Look & sound. Pro is coming soon." replaces the pre-launch "Coming
soon: a fresh new look…" (
packages/shared/announcements.js).the style the boards draw.
docs/FEATURE_FLAGS.md: PostHog flag, yourself, friendly clubs,everyone, then delete today's panel when the flag retires.
Security
None.
Production impact
None while
new_lookis off: the dialogs only change inside design B's shell. The announcementchange applies only where
new_lookis on, so production users still see the same pre-launch notice.Testing
npm test: 130 files, 2438 tests pass. New:Phase3.test.jsx(Upgrade as a sheet and today'sdialog outside B, the launch card, the club question sheet, the stage label) and the new-look
announcement cases.
npm run test:e2e: 70 passed. New inzoom.new-look.spec.js: the top note, the Pro chip openingUpgrade as a sheet, and the full-screen timer opened from its sheet with the share label.
npm run test:specs: 14 valid, no drift. Added:new-lookNL-17 to NL-20,announcement-bannerAB-05,pro-launchPL-05.Evidence (real Zoom client)
Not run yet. All of plan 13's Zoom-client runs happen together now that the last phase is built.
They need dev deployed from this branch. That waits until #145's CC-10 has run on the test device:
dev has to keep serving #145's fix, and device A's club token has to age untouched until then.
Not verified
Every Zoom-client step for plan 13, until that run:
new-lookNL-01 to NL-20announcement-bannerAB-05pro-launchPL-05new_lookoff:timer-core,timer-sounds,club-card-sets,agenda-import,club-pro-gate,announcement-bannerLook here first
apps/zoom-app/src/components/UpgradeModal.jsx: thelook === 'b'branch (the rest is untouched).packages/shared/announcements.js: the two conditions.