Repository navigation
Design B, Phase 2: Agenda, Report, Roles & timing rules (behind new_look) - #155
Draft
ShuhaoZQGG wants to merge 3 commits into
Draft
ShuhaoZQGG wants to merge 3 commits into
ShuhaoZQGG wants to merge 3 commits into
Conversation
useAgendaEditor, useReportView and useRulesEditor hold what AgendaTab, ReportTab and EditRulesModal did, moved unchanged (their JSX is byte-for-byte the same and their tests pass as written). Design B's views call the same hooks.
Agenda: empty state with Paste from EasySpeak / Add a speaker, rows with drag dots, ON THE TIMER, finished times and the red needs-role row, a paste sheet that counts speakers before adding, an add / edit sheet. Report: rows with colour, time and OVER TIME, copy, clear, the club archive, history and share as sheets, the Pro pitch only while Pro can be bought. Roles & timing rules: one row per role, one open at a time, the club's list and sharing.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Plan 13, Phase 2 of design B: the Agenda and Report tabs and the Roles & timing rules sheet.
Stacked on #154 (Phase 1, itself on #153); the diff is Phase 2 only.
Why
The approved boards B-G01–G04 (Agenda), B-R01–R04 (Report) and B-L08 (Roles & timing rules).
What changes
Only with
new_lookon:takes a typed name.
and the red needs-role row with its role picker. Edit and remove show on hover.
adding.
clubFeaturesOn): the "Saved to " strip, History, and Endmeeting & share, now as sheets.
proon), and never to a Pro plan.Yellow, Red and Grace. Reset, remove, Add role, the club's list ("Using 's timings · Use mine"),
sharing with the club, Reset all and Save. It replaces the old dialog in the new look (⋯ menu, "Edit
rules", and the role list).
useAgendaEditor,useReportViewanduseRulesEditorhold the logic of AgendaTab,ReportTab and EditRulesModal. It was moved unchanged: their JSX is byte-for-byte the same and their
tests pass as written. The new views in
apps/zoom-app/src/b/call the same hooks.Security
None. No new routes. The club archive and share use the existing endpoints.
Production impact
None while
new_lookis off. Today's tabs render exactly as before. Rollback is a revert.Testing
npm test: 129 files, 2432 tests pass. New:AgendaReport.test.jsx, covering:npm run test:e2e: 67 passed. New cases inzoom.new-look.spec.js:npm run test:specs: 14 valid, no drift.count, report rows with OVER TIME and a comment, the rules sheet.
Evidence (real Zoom client)
Held until plan 13's last phase, as asked.
Not verified
Held until the last phase:
new-lookNL-13 to NL-16 (new), not run.agenda-importandclub-pro-gate(their covered code moved into hooks), withnew_lookoff.Look here first
apps/zoom-app/src/b/AgendaTabB.jsx: rows and the two sheets.apps/zoom-app/src/b/ReportTabB.jsx: the club parts and the Pro pitch gate.apps/zoom-app/src/b/RulesSheet.jsx: mounted only while open, as the old dialog was, so each openstarts from the live rules.