Skip to content

feat(settings): adjust ambient intensity with the scroll wheel - #551

Merged
A-EDev merged 1 commit into
mainfrom
feat/ambient-intensity-wheel
Nov 10, 2026
Merged

A-EDev merged 1 commit into
mainfrom
feat/ambient-intensity-wheel

Conversation

@A-EDev

@A-EDev A-EDev commented Nov 10, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Scrolling over the ambient mode intensity slider in Settings changes it in steps of 5, the way the volume controls react to the wheel.
  • The wheel does nothing to the slider while ambient mode is off, so the page scrolls as usual.
  • A small useWheelValue hook does this for any range control, reusing the wheel step logic from wheelVolume.ts.

Captain-Vikram's commit, moved out of #414 so that PR covers only #413. The only change to it is text-end in place of text-right for right-to-left layouts.

Related issue

Change type

  • Bug fix
  • Feature
  • Refactor or maintenance
  • Documentation
  • Build, packaging, or CI

Validation

  • pnpm test (387 files, 2295 tests, 0 failures)
  • pnpm build (tsc and vite build pass)
  • cargo fmt --manifest-path src-tauri/Cargo.toml --all -- --check
  • cargo clippy --manifest-path src-tauri/Cargo.toml --all-targets --all-features
  • cargo test --manifest-path src-tauri/Cargo.toml --all-targets --all-features
  • I smoke-tested the affected desktop behavior.

No Rust files change. Not run in the app yet.

Screenshots or recordings

Risk and compatibility

  • No new secrets, private data, telemetry, or broad Tauri permissions were introduced.
  • User-facing documentation was updated where needed.
  • Dependency and lockfile changes are intentional and limited to this PR.
  • Breaking changes and upgrade steps are clearly documented.

Settings page only. No database, network or playback change.

Copilot AI balanced review requested due to automatic review settings November 10, 2026 17:31

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

@A-EDev
A-EDev merged commit b19fe19 into main Nov 10, 2026
7 checks passed
@A-EDev
A-EDev deleted the feat/ambient-intensity-wheel branch November 10, 2026 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants