Skip to content

feat(player): close the music volume popover and fade the mini player buttons when idle - #414

Merged
A-EDev merged 9 commits into
Flow-Tube:mainfrom
Captain-Vikram:feat/issue-413-transient-controls-inactivity
Nov 10, 2026
Merged

A-EDev merged 9 commits into
Flow-Tube:mainfrom
Captain-Vikram:feat/issue-413-transient-controls-inactivity

Conversation

@Captain-Vikram

@Captain-Vikram Captain-Vikram commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • The volume popover in the music bar and the full music player closes after 2.8 seconds untouched. It stays open while the pointer is on it or keyboard focus is inside, then waits at least 1.5 seconds. Each volume change starts the count again. This uses the existing useToastTimer.
  • Scrolling over the music volume button while the popover is closed shows the new level for a moment.
  • The video player, the music bar and the full music player now share one volume pill (VolumeFeedbackPill) and one useVolumeFeedback hook, in place of three copies.
  • The mini player's controls follow the full player's idle rule: while a video plays, the move handle, Expand and Close fade with the bottom controls after 2.4 seconds. They stay up while paused, loading or failed, and while the pointer rests on the buttons.

The ambient intensity wheel commit moved to #551.

Related issue

Closes #413

Change type

  • Bug fix
  • Feature
  • Refactor or maintenance
  • Documentation
  • Build, packaging, or CI

Validation

  • pnpm test (387 files, 2294 tests, 0 failures)
  • pnpm build (tsc and vite build pass)
  • cargo fmt --manifest-path src-tauri/Cargo.toml --all -- --check
  • cargo clippy --manifest-path src-tauri/Cargo.toml --all-targets --all-features
  • cargo test --manifest-path src-tauri/Cargo.toml --all-targets --all-features
  • I smoke-tested the affected desktop behavior.

No Rust files change. Tests cover the popover's close timing, hover hold and restart on a volume change, and the mini player buttons following the player's controls and holding under the pointer. Not run in the app yet.

Screenshots or recordings

Risk and compatibility

  • No new secrets, private data, telemetry, or broad Tauri permissions were introduced.
  • User-facing documentation was updated where needed.
  • Dependency and lockfile changes are intentional and limited to this PR.
  • Breaking changes and upgrade steps are clearly documented.

Frontend only. The mini player now hides its bottom controls and the cursor after 2.4 seconds of playback, as the full player does; before, they stayed up while the pointer was inside. No database, network or playback change.

@Captain-Vikram
Captain-Vikram force-pushed the feat/issue-413-transient-controls-inactivity branch from 6f57b5d to 51dc6ab Compare November 4, 2026 19:42
2ax4 pushed a commit to 2ax4/Flow-Desktop that referenced this pull request Nov 6, 2026
A-EDev and others added 6 commits November 10, 2026 19:12
Co-authored-by: Captain-Vikram <vighneshkontham@gmail.com>
…ent-controls-inactivity

# Conflicts:
#	src/components/music/GlobalMusicDock.tsx
#	src/components/music/MusicOverlay.tsx
#	src/components/watch/GlobalVideoPlayer.tsx
…layers

Co-authored-by: Captain-Vikram <vighneshkontham@gmail.com>
Co-authored-by: Captain-Vikram <vighneshkontham@gmail.com>
…rols

Co-authored-by: Captain-Vikram <vighneshkontham@gmail.com>
Co-authored-by: Captain-Vikram <vighneshkontham@gmail.com>
@A-EDev A-EDev changed the title feat(player): auto-dismiss transient music volume controls and restin… feat(player): close the music volume popover and fade the mini player buttons when idle Nov 10, 2026
…ent-controls-inactivity

# Conflicts:
#	changelog/v0.1.0-beta4.txt
@A-EDev
A-EDev merged commit efe3faf into Flow-Tube:main Nov 10, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature]: Inactivity auto-dismissal for transient music volume controls and resting mini-player chrome

2 participants