Repository navigation
fix(player): let the ambient glow show through the top bar above the player - #442
Merged
A-EDev merged 8 commits intoNov 10, 2026
Merged
Conversation
# Conflicts: # src/components/settings/tabs/PlayerTab.tsx
…n main Co-authored-by: Captain-Vikram <vighneshkontham@gmail.com>
…player Co-authored-by: Captain-Vikram <vighneshkontham@gmail.com>
Co-authored-by: Captain-Vikram <vighneshkontham@gmail.com>
Co-authored-by: Captain-Vikram <vighneshkontham@gmail.com>
Collaborator
|
Thanks! I merged main and changed a few things:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Related issue
Change type
Validation
pnpm test(393 files, 2326 tests, 0 failures)pnpm build(tsc and vite build pass)cargo fmt --manifest-path src-tauri/Cargo.toml --all -- --checkcargo clippy --manifest-path src-tauri/Cargo.toml --all-targets --all-featurescargo test --manifest-path src-tauri/Cargo.toml --all-targets --all-featuresNo Rust files change. Tests cover the bar at each edge (glow on and the player below it, the player under it, no spread glow, off the watch page) and the player tracker's report for a player below and under the bar. Not run in the app yet.
Screenshots or recordings
Risk and compatibility
Frontend only. The extra work per scroll frame is one cached read of where the page starts.