Skip to content

fix(player): let the ambient glow show through the top bar above the player - #442

Merged
A-EDev merged 8 commits into
Flow-Tube:mainfrom
Captain-Vikram:fix/issue-369-ambient-mode
Nov 10, 2026
Merged

A-EDev merged 8 commits into
Flow-Tube:mainfrom
Captain-Vikram:fix/issue-369-ambient-mode

Conversation

@Captain-Vikram

@Captain-Vikram Captain-Vikram commented Nov 7, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • With the ambient glow on, the glow above the video on the watch page shows through the top bar instead of stopping at its edge.
  • The bar is see-through only while the player sits below it. It turns solid with no fade as soon as the video reaches it, so the picture never shows behind the search box, in theater mode too.
  • The player tracker, which already reads the player's position on every scroll frame, reports whether the player is below the bar. The player reports whether its glow spreads past it.

Related issue

Change type

  • Bug fix
  • Feature
  • Refactor or maintenance
  • Documentation
  • Build, packaging, or CI

Validation

  • pnpm test (393 files, 2326 tests, 0 failures)
  • pnpm build (tsc and vite build pass)
  • cargo fmt --manifest-path src-tauri/Cargo.toml --all -- --check
  • cargo clippy --manifest-path src-tauri/Cargo.toml --all-targets --all-features
  • cargo test --manifest-path src-tauri/Cargo.toml --all-targets --all-features
  • I smoke-tested the affected desktop behavior.

No Rust files change. Tests cover the bar at each edge (glow on and the player below it, the player under it, no spread glow, off the watch page) and the player tracker's report for a player below and under the bar. Not run in the app yet.

Screenshots or recordings

Risk and compatibility

  • No new secrets, private data, telemetry, or broad Tauri permissions were introduced.
  • User-facing documentation was updated where needed.
  • Dependency and lockfile changes are intentional and limited to this PR.
  • Breaking changes and upgrade steps are clearly documented.

Frontend only. The extra work per scroll frame is one cached read of where the page starts.

@A-EDev A-EDev changed the title fix(player): bleed ambient glow behind top bar, scale outer intensity, and adjust with wheel fix(player): let the ambient glow show through the top bar above the player Nov 10, 2026
@A-EDev

A-EDev commented Nov 10, 2026

Copy link
Copy Markdown
Collaborator

Thanks! I merged main and changed a few things:

  • The scroll wheel commit was already merged as feat(settings): adjust ambient intensity with the scroll wheel #551, so it drops out.
  • The intensity slider already sets the glow's strength in the pipeline (gain = 0.28 × intensity / 60). Scaling the opacity too applied the slider twice, so at the default 60 the glow drew at 60% opacity. I removed that and the 160 to 150 px change, to keep the look from fix(player): add an in-player ambient toggle and port the Android glow #378.
  • The see-through top bar stays, but it now follows the player's position instead of a 20 px scroll threshold. In theater there's no top padding, so with the threshold the video slid under the clear bar. Now the player tracker reports when the player is below the bar, and the bar turns solid with no fade as soon as the video reaches it. It's only clear while the glow spreads past the player.
  • I couldn't find a case where the cached slot in the scroll tracker goes stale: the effect re-runs on every route change, and theater keeps the same slot. So I took that change out. If you can reproduce the frozen scrolling, please open an issue with the steps.

I also removed "Closes #369", since #378 already closed it.

@A-EDev
A-EDev merged commit 2cd590b into Flow-Tube:main Nov 10, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants