Skip to content

fix(deps): bump happy-dom past the high-severity advisory - #766

Merged
zaebee merged 1 commit into
mainfrom
fix/dependabot-happy-dom
Oct 31, 2026
Merged

zaebee merged 1 commit into
mainfrom
fix/dependabot-happy-dom

Conversation

@zaebee

@zaebee zaebee commented Oct 31, 2026

Copy link
Copy Markdown
Owner

Dependabot alert #49: GHSA-834v-8h66-3h79 / CVE-2026-115895, high severity — the incomplete fix for CVE-2026-33943: an unsanitized import alias in Happy DOM leads to host code execution.

Vulnerable happy-dom >= 17.0.0, <= 21.0.3
Patched 21.0.4
Manifest ui/package.json

ui/ declares both packages directly (happy-dom, @happy-dom/global-registrator), so both move from ^20.10.2 to ^21.0.4; the registrator's dependency is happy-dom ^21.0.4, so the lock keeps a single copy.

Diff

  • ui/package.json: 2 lines
  • ui/bun.lock: 4 lines — the two declarations and the two resolutions; nothing else re-resolved

Verification (pinned bun 1.3.14, same as .github/workflows/ui.yml)

  • bun install --frozen-lockfile --ignore-scripts — no changes
  • bun run lint — clean
  • bun run format:check — clean
  • bun run typecheck — clean
  • bun run test:run — vitest, 9.5s, passed
  • bun run build — 487.67 kB bundle, built in 717ms

The alert should close on Dependabot's next scan; the advisory's vulnerable range no longer matches anything in the lock.

GHSA-834v-8h66-3h79 / CVE-2026-115895 is the incomplete fix for
CVE-2026-33943: an unsanitized import alias in Happy DOM leads to host
code execution. The vulnerable range is >= 17.0.0, <= 21.0.3; 21.0.4
patches it.

ui/ declares both packages directly, so both move from ^20.10.2 to
^21.0.4, and @happy-dom/global-registrator@21.0.4 depends on
happy-dom ^21.0.4, so the lock keeps one copy. The lockfile diff is
four lines - the two declarations and the two resolutions; nothing
else re-resolved.

Verified with the pinned bun the UI workflow uses (1.3.14): frozen
install, eslint, prettier --check, tsc --noEmit, vitest run (9.5s),
vite build - all green.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the @happy-dom/global-registrator and happy-dom development dependencies in the ui package from version 20.10.2 to 21.0.4 within both package.json and bun.lock. There are no review comments, and I have no feedback to provide.

@sonarqubecloud

Copy link
Copy Markdown

@zaebee
zaebee merged commit b9f6464 into main Oct 31, 2026
6 checks passed
@zaebee
zaebee deleted the fix/dependabot-happy-dom branch October 31, 2026 11:36
zaebee added a commit that referenced this pull request Oct 31, 2026
ui.yml listed feat/**, fix/** and docs/** in its push trigger next to the
pull_request trigger, so every push to a PR branch started it twice on one
SHA. #766 showed both: UI Verification passed at 18s (push) and 22s
(pull_request).

ci.yml lost the same patterns in #756 for the same reason; ui.yml was
missed then. Keep main and dev — a pull_request event only covers PRs
into main — and let the path filter do the rest.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant