Repository navigation
fix(deps): bump happy-dom past the high-severity advisory - #766
Merged
Merged
Conversation
GHSA-834v-8h66-3h79 / CVE-2026-115895 is the incomplete fix for CVE-2026-33943: an unsanitized import alias in Happy DOM leads to host code execution. The vulnerable range is >= 17.0.0, <= 21.0.3; 21.0.4 patches it. ui/ declares both packages directly, so both move from ^20.10.2 to ^21.0.4, and @happy-dom/global-registrator@21.0.4 depends on happy-dom ^21.0.4, so the lock keeps one copy. The lockfile diff is four lines - the two declarations and the two resolutions; nothing else re-resolved. Verified with the pinned bun the UI workflow uses (1.3.14): frozen install, eslint, prettier --check, tsc --noEmit, vitest run (9.5s), vite build - all green.
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the @happy-dom/global-registrator and happy-dom development dependencies in the ui package from version 20.10.2 to 21.0.4 within both package.json and bun.lock. There are no review comments, and I have no feedback to provide.
|
zaebee
added a commit
that referenced
this pull request
Oct 31, 2026
ui.yml listed feat/**, fix/** and docs/** in its push trigger next to the pull_request trigger, so every push to a PR branch started it twice on one SHA. #766 showed both: UI Verification passed at 18s (push) and 22s (pull_request). ci.yml lost the same patterns in #756 for the same reason; ui.yml was missed then. Keep main and dev — a pull_request event only covers PRs into main — and let the path filter do the rest.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Dependabot alert #49: GHSA-834v-8h66-3h79 / CVE-2026-115895, high severity — the incomplete fix for CVE-2026-33943: an unsanitized import alias in Happy DOM leads to host code execution.
happy-dom >= 17.0.0, <= 21.0.3ui/package.jsonui/declares both packages directly (happy-dom,@happy-dom/global-registrator), so both move from^20.10.2to^21.0.4; the registrator's dependency ishappy-dom ^21.0.4, so the lock keeps a single copy.Diff
ui/package.json: 2 linesui/bun.lock: 4 lines — the two declarations and the two resolutions; nothing else re-resolvedVerification (pinned bun 1.3.14, same as
.github/workflows/ui.yml)bun install --frozen-lockfile --ignore-scripts— no changesbun run lint— cleanbun run format:check— cleanbun run typecheck— cleanbun run test:run— vitest, 9.5s, passedbun run build— 487.67 kB bundle, built in 717msThe alert should close on Dependabot's next scan; the advisory's vulnerable range no longer matches anything in the lock.