Repository navigation
ci(ui): run the UI workflow once per PR branch - #768
Merged
Merged
Conversation
ui.yml listed feat/**, fix/** and docs/** in its push trigger next to the pull_request trigger, so every push to a PR branch started it twice on one SHA. #766 showed both: UI Verification passed at 18s (push) and 22s (pull_request). ci.yml lost the same patterns in #756 for the same reason; ui.yml was missed then. Keep main and dev — a pull_request event only covers PRs into main — and let the path filter do the rest.
Contributor
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



ui.ymllistedfeat/**,fix/**anddocs/**in itspushtrigger next to thepull_requesttrigger, so every push to a PR branch started the workflow twice on one SHA.Seen on #766: two identical UI Verification checks, 18s (push) and 22s (pull_request).
ci.ymllost the same patterns in #756 for exactly this reason;ui.ymlwas missed then because #756 only touchedci.yml.Change
on.push.branches:[main, dev, "feat/**", "fix/**", "docs/**"]→[main, dev]ci.yml's version of itdevstays: apull_requestevent only covers PRs intomainVerification
This PR itself is the check: it edits
ui.yml, so the path filter matches. After the change there should be exactly one UI Verification run on it, frompull_request.