Repository navigation
Conversation
- MRDebug::Breakpoint mixin: active?/deactivate!, numbered_line and number_in(siblings) for the three breakpoint classes. - MRDebug.env_value moves to core and replaces Colorizer.env. - MRDebug.start_session(ui) replaces four copies of the Session.new/ui=/session= sequence (device.rb, mrdebug-console). - Transport.read_some replaces copies in CLI, DapServer, DeviceLink and Transport::Socket. - CLI.connect_tcp/connect_unix share connect_and_relay. - DapBridge: arguments(request), and one breakpoints_response for both the handshake and the stopped phase. - mrdebug-console's color check is now Colorizer.enabled?(nil): a nil io means nothing to probe. It now also honors TERM=dumb. - OwnSource::FILES lists every Ruby source again (device.rb, socket.rb, cli/*, console.rb, ... were missing); spec/own_source_spec.rb fails when it drifts from the tree. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CpfQQRdc3R13RafigfCNVk
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CpfQQRdc3R13RafigfCNVk
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #41.
MRDebug::Breakpointmixin (mrblib/mrdebug/breakpoint.rb):active?/deactivate!,numbered_line,number_in(siblings). These were copied acrossLineBreakpoint/MethodBreakpoint/WatchVarBreakpoint.MRDebug.env_valuemoves to core (mrblib/mrdebug.rb) and replacesColorizer.env, which was identical.MRDebug.start_session(ui)replaces four copies ofSession.new/ui=/self.session=(listen_tcp,listen_unix,attach_stdio, mrdebug-console'sattach_local).Transport.read_some(io)replaces thesysread/readpartialswitch that was repeated inCLI,DapServer,DeviceLinkandTransport::Socket.CLI.connect_tcp/connect_unixshareconnect_and_relay. A misplaced doc comment now sits onrelayinstead ofcolorizer_for.DapBridge:arguments(request)helper.setBreakpoints/setFunctionBreakpointsare handled once (breakpoints_response) instead of in both the handshake and stoppedcase.Colorizer.enabled?(nil)(anilio means there's nothing to probe). Small behavior change: it now also honorsTERM=dumb, the same as the host side.OwnSource::FILESlists every Ruby source again.device.rb,transport/socket.rb,cli/*,remote_session.rbandconsole.rbwere missing. The newspec/own_source_spec.rbcompares the list against the tree, so it can't silently drift again.CLAUDE.md is updated to match.
Tested:
rake test:unit(OK 3015, KO 0),rake test:smokeandrake picoruby:smoke(4 examples, 0 failures each). The mrdebug-console gem isn't built by CI and wasn't compiled here; its changes are two one-line call-site swaps.🤖 Generated with Claude Code
https://claude.ai/code/session_01CpfQQRdc3R13RafigfCNVk