Repository navigation
Conversation
- set_session/disarm replace the reset code repeated across install, uninstall and gem_final; gem_final now also releases the session and the cached filename string. - invoke_on_line takes `forced` directly (invoke_on_line_forced is gone); report_position looks up the filename once for all three call sites. - Drop the always-true deferred_bp/in_callback checks before check_method_call. - frame.c: paused_frame for the context lookup frame_position and frame_binding both did. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CpfQQRdc3R13RafigfCNVk
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #42.
set_session/disarmreplace reset code that was repeated inhook_s_install,hook_s_uninstallandmrb_mrdebug_gem_final.disarmstill leavesin_callbackalone, since uninstall can run mid-callback viaMRDebug.detach.gem_finalnow also releases the session and the cached filename string; before, they stayed GC-registered.invoke_on_linetakesforceddirectly, so theinvoke_on_line_forcedwrapper is gone.report_positiondoes the filename lookup andfilename_valuecall that three call sites used to repeat.mrb_nil_p(hook.deferred_bp) && !hook.in_callbackguard beforecheck_method_call. It was always true at that point:on_linenever setsdeferred_bp, andrun_in_dbg_contexthas already clearedin_callback.frame.c:paused_frame()does the paused-context +frame_atlookup thatframe_positionandframe_bindingboth repeated.Tested:
rake test:unit: OK 3015, KO 0rake test:smokeandrake picoruby:smoke: 0 failures eachb Foo#bar,b Array#sort,p,bt): same output as before🤖 Generated with Claude Code
https://claude.ai/code/session_01CpfQQRdc3R13RafigfCNVk