Repository navigation
Conversation
- New MRDebug::Protocol holds the prompt, stop-banner prefixes, the
"added at" reply, "Usage: ", EVAL_ERROR and NO_BINDING. Command, the
breakpoint banners, DeviceLink, DapBridge, Colorizer, LocalConsole and
the on-device Console all use it instead of their own literals.
- Command.dispatch: resuming verbs go through .resume; every other verb
maps to <verb>_cmd(session, arg), replacing the 18-arm case.
- Hand-rolled index loops replaced by core String#index/#rindex.
- break's reply reuses the breakpoint's own #to_s.
- Repeated messages (no position, no filesystem, invalid line) are
constants; list/cat share source_lines.
- Character-class helpers (digit?/lower?/upper?/space?/word_char?/digits?)
live in Command and back RubyHighlighter, Json and MRDebug.default_port.
- MRDebug.error_text replaces four copies of "#{e.class}: #{e.message}".
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01CpfQQRdc3R13RafigfCNVk
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #40. No change to any command's output.
MRDebug::Protocol(mrblib/mrdebug/protocol.rb): the(mrdbg)prompt,Breakpoint/Watchpoint/Stop:banner prefixes,added at,Usage:,EVAL_ERROR,NO_BINDING. Producers (Command, stop banners) and host-side parsers (DeviceLink,DapBridge,Colorizer) plusLocalConsole/Consolenow share these instead of separate literals, so a wording change can't silently break DAP parsing or coloring. Added toOwnSource::FILESand CLAUDE.md.Command.dispatch: resuming verbs go through.resume; every other verb maps to<verb>_cmd(session, arg)(replaces the 18-armcase).char_index/last_dot_index/last_colon_index/find_if_clause→ coreString#index/#rindex(core, so safe under mrbtest).break's reply reuses the breakpoint's own#to_sinstead of rebuilding the label.NO_POSITION,NO_FILESYSTEM,INVALID_LINE);list/catsharesource_lines.digit?/lower?/upper?/space?/word_char?/digits?) live once inCommandand backRubyHighlighter,Json::ParserandMRDebug.default_port(which had its owndigits?).MRDebug.error_text(e)replaces four copies of"#{e.class}: #{e.message}".Tested:
rake test:unit(OK 3015, KO 0, Crash 0 — same as before),rake test:smoke(0 failures).🤖 Generated with Claude Code
https://claude.ai/code/session_01CpfQQRdc3R13RafigfCNVk