feat: add the generative-meta module (Weaviate 1.39.3) - #374
Merged
Merged
Conversation
There was a problem hiding this comment.
Orca Security Scan Summary
| Status | Check | Issues by priority | |
|---|---|---|---|
| Secrets | View in Orca |
Summary - Weaviate C# Client CoverageSummary
CoverageWeaviate.Client - 49.7%
Weaviate.Client.Analyzers - 0%
Weaviate.Client.VectorData - 50.3%
|
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The implementation matches the server contracts and includes focused unit and integration coverage.
Pull request overview
Adds generative-meta support for Weaviate 1.39.3 across collection configuration, runtime gRPC providers, serialization, and testing.
Changes:
- Adds Meta collection and runtime provider models and factories.
- Syncs Meta protobuf definitions and maps runtime settings to gRPC.
- Adds unit/integration coverage and updates CI to exercise Weaviate 1.39.3.
File summaries
| File | Description |
|---|---|
src/Weaviate.Client/PublicAPI.Unshipped.txt |
Tracks the new public Meta APIs. |
src/Weaviate.Client/Models/Serialization.GenerativeConfig.cs |
Deserializes Meta collection configuration. |
src/Weaviate.Client/Models/GenerativeConfig.cs |
Defines Meta collection settings. |
src/Weaviate.Client/Models/Generative/Providers.cs |
Defines the runtime Meta provider. |
src/Weaviate.Client/gRPC/Search.Builders.cs |
Maps Meta runtime settings to protobuf. |
src/Weaviate.Client/gRPC/proto/v1/generative.proto |
Vendors Meta request and metadata messages. |
src/Weaviate.Client/Configure/GenerativeProvider.cs |
Adds the runtime provider factory. |
src/Weaviate.Client/Configure/GenerativeConfig.cs |
Adds the collection configuration factory. |
src/Weaviate.Client.Tests/Unit/TestGenerativeShortcuts.cs |
Tests Meta gRPC request mapping. |
src/Weaviate.Client.Tests/Unit/TestCollection.cs |
Tests REST serialization and round-tripping. |
src/Weaviate.Client.Tests/Integration/TestCollections.cs |
Tests configuration against a real server. |
ci/docker-compose.yml |
Enables the Meta module in integration environments. |
.github/workflows/main.yaml |
Updates the CI matrix to Weaviate 1.39.3. |
Review details
- Files reviewed: 13/13 changed files
- Comments generated: 0
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
g-despot
force-pushed
the
feat/generative-digitalocean
branch
from
September 10, 2026 08:43
249b494 to
1349321
Compare
g-despot
force-pushed
the
feat/generative-meta
branch
from
September 10, 2026 08:46
abc4231 to
5363553
Compare
dirkkul
approved these changes
Sep 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the generative-meta module (server v1.39.3), following the same pattern as #373: collection config + runtime provider + gRPC mapping, vendored proto sync, and tests folded into the existing tables. reasoningEffort follows the OpenAI precedent — string on the REST config, enum on the gRPC provider (Meta's numbering differs from OpenAI's).
Stacked on #373; the 1.39.0 CI matrix leg is bumped to 1.39.3 so one leg exercises the gated integration test.
Follow-up: the proto's GenerativeMeta carries runtime images/image_properties (Meta is multimodal over gRPC); they are vendored in the proto but not yet exposed on Providers.Meta, matching the issue's settings list.
Closes #372