feat: add centered RQ4 quantization (Weaviate 1.39.3) - #375
Merged
Merged
Conversation
![orca-security-eu[bot]](https://avatars.githubusercontent.com/in/276244?s=60&v=4){kind=small}
There was a problem hiding this comment.
Orca Security Scan Summary
| Status | Check | Issues by priority | |
|---|---|---|---|
 Passed |
Infrastructure as Code |  0  0  0  0 |
View in Orca |
| Passed |
SAST | 0 0 0 0 |
View in Orca |
| Passed |
Secrets | 0 0 0 0 |
View in Orca |
| Passed |
Vulnerabilities | 0 0 0 0 |
View in Orca |
Summary - Weaviate C# Client CoverageSummary
CoverageWeaviate.Client - 49.7%
Weaviate.Client.Analyzers - 0%
Weaviate.Client.VectorData - 50.3%
|
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Integration coverage does not verify the advertised RQ update path or preservation of immutable settings.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Adds centered RQ4 configuration support for Weaviate 1.39.3.
Changes:
- Adds
CenteringandTrainingLimitto RQ configuration. - Tracks the new public API members.
- Adds serialization and version-gated integration coverage.
File summaries
| File | Description |
|---|---|
src/Weaviate.Client/PublicAPI.Unshipped.txt |
Tracks new RQ properties. |
src/Weaviate.Client/Models/VectorIndex.cs |
Defines centered RQ4 settings. |
src/Weaviate.Client.Tests/Unit/TestVectorIndexConfig.cs |
Tests serialization and round-tripping. |
src/Weaviate.Client.Tests/Integration/TestCollections.cs |
Tests centered RQ4 creation and retrieval. |
Review details
- Files reviewed: 4/4 changed files
- Comments generated: 1
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
dirkkul
approved these changes
Sep 11, 2026
g-despot
force-pushed
the
feat/centered-rq4
branch
from
September 14, 2026 08:31
9152c74 to
a5ed1bb
Compare
From 1.39.3 the server echoes trainingLimit on every RQ config it returns, so the check made read-modify-write of any RQ8 collection fail client-side (caught by Test_sq_and_rq in CI). Centering-only guard restored.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the two new optional fields on the RQ quantizer config — centering (bool) and trainingLimit (int) — mirroring the Python implementation (weaviate/weaviate-python-client#2148) and core PR weaviate/weaviate#12502. The one record change covers create, config-response parsing, and update, since all DTOs share the RQ record.
The client rejects centering without bits: 4 with a clear error at serialization time (same mechanism as the HFresh guard). trainingLimit is deliberately not guarded: from 1.39.3 the server echoes it on every RQ config it returns, so a client-side check breaks read-modify-write of plain RQ8 collections (a guard on it was tried and reverted in this branch after CI caught exactly that). Other constraints (immutability on update) stay server-side.
The integration test is gated RequireVersion("1.39.3") — deliberately not Python's 1.39.2, which is off by one (the feature ships in v1.39.3 only).
Closes #371