Skip to content

feat: Support numeric keyboard hints for text fields (#36) - #37

Merged
efraespada merged 4 commits into
developfrom
feature/36-support-numeric-keyboard-hints-for-text-fields
Nov 19, 2026
Merged

efraespada merged 4 commits into
developfrom
feature/36-support-numeric-keyboard-hints-for-text-fields

Conversation

@efraespada

@efraespada efraespada commented Nov 19, 2026 •

Copy link
Copy Markdown
Member

Add an optional numeric keyboard hint to the shared text field for integer identifiers such as GTINs. The field remains a text input and preserves exact strings, including leading zeroes, through controlled updates and form submission.

What changed

  • Accept inputMode: 'numeric' alongside decimal in the validated public text-field state.
  • Document identifier behavior and add English and Spanish numeric-field catalog examples.
  • Update consumer fixtures and package coordinates to 0.1.0-next.3.
  • Align row keyboard acceptance with the browser engine’s native Tab policy.

Validation

  • The author reports 105 field contract tests and 37 native field tests passing, with 1,481 tests passing overall and 100% coverage across statements, branches, functions, and lines.
  • The author reports strict TypeScript, consumer compilation, Svelte checks, packed archive reproducibility, and direct DOM and installed framework browser lifecycles passing.
  • The author reports Next.js, Nuxt, and SvelteKit production clients preserve leading-zero form values with zero console errors or external requests.
  • The author reports all ten static catalog groups passing and Chromium, Firefox 157, and WebKit passing the compiled browser matrix.

Closes #36

@docs-page

docs-page Bot commented Nov 19, 2026

Copy link
Copy Markdown

To preview the documentation for this pull request, visit the following URL:

docs.page/vypdev/ha-ui~37

Documentation is deployed and generated using docs.page

@vypbot vypbot added the state:ai-processing A Copilot agent is analyzing or working on the issue or change. label Nov 19, 2026
@vypbot vypbot changed the title Support numeric keyboard hints in text fields feat: Support numeric keyboard hints for text fields (#36) Nov 19, 2026
@vypbot
vypbot self-requested a review November 19, 2026 13:47
@vypbot vypbot added this to vypdev Nov 19, 2026
@vypbot vypbot moved this to In Progress in vypdev Nov 19, 2026
@vypbot
vypbot changed the base branch from develop to master November 19, 2026 13:47
@efraespada efraespada linked an issue Nov 19, 2026 that may be closed by this pull request
1 task done
@vypbot vypbot added the size: XXL Label to indicate a task of size XXL label Nov 19, 2026
@vypbot
vypbot changed the base branch from master to develop November 19, 2026 13:48
@vypbot

vypbot commented Nov 19, 2026 •

Copy link
Copy Markdown
Contributor

Bugbot: review complete

Current status: No active findings on daba2fb.

Pull request · Verified commit · Workflow run

@vypbot vypbot added state:ready The change is ready for human approval or merge. state:awaiting-maintainer The next action requires a maintainer response or approval. and removed state:ai-processing A Copilot agent is analyzing or working on the issue or change. labels Nov 19, 2026
@vypbot

vypbot commented Nov 19, 2026 •

Copy link
Copy Markdown
Contributor

Copilot approval · Approval blocked

Status: Effective branch rules must be readable and dismiss stale approvals.
Completed: 2/3 observed checks succeeded; Bugbot complete.
Action required: Fix the named prerequisite and rerun the observer.
Impact: No new approval is confirmed for this revision.
See checks

Technical evidence

Revision: daba2fbbdb80; base: 0bc09da42543; reason: unsafe-rules.

@vypbot vypbot added the state:ai-processing A Copilot agent is analyzing or working on the issue or change. label Nov 19, 2026
@vypbot vypbot removed the state:ai-processing A Copilot agent is analyzing or working on the issue or change. label Nov 19, 2026
@vypbot vypbot added state:ai-processing A Copilot agent is analyzing or working on the issue or change. and removed state:ai-processing A Copilot agent is analyzing or working on the issue or change. labels Nov 19, 2026
@efraespada

Copy link
Copy Markdown
Member Author

Verification follow-up

The first source campaign completed the full product, package, SSR, compiled catalog and Linux three-engine suites. Its subsequent specification-index step failed because the native publisher's generated header and maintenance text differ from the consumer's original pinned renderer. Commit daba2fbbdb80da47e939d3e3d76fc76b7f195c97 regenerates only specs/CATALOG.md with that installed SDK, and the same validator passes locally. The selected companion and both prior owners remain byte-identical. Publication incident

The separate approval observer refuses the existing unprotected develop configuration with unsafe-rules. The branch-rules endpoint is readable and returns an empty list; classic protection returns 404. The maintainer-authorized Copilot-only exception applies after the final product CI, Branch Sync and complete zero-finding review succeed. The ordinary GitHub merge route will be used. Recorded approval prerequisite

Local acceptance also passes 1,481 tests with 100% global/per-file coverage, all five reproducible packed coordinates, all four framework lifecycles, actual Next.js/Nuxt/SvelteKit clients, all ten static-catalog groups and Chromium/Firefox/WebKit. The local macOS Firefox run uses fresh synthetic app data for the upstream shared-profile issue. Those temporary roots have been retired after closing the browsers.

@efraespada

efraespada commented Nov 19, 2026 •

Copy link
Copy Markdown
Member Author

The final producer workflow completed successfully at exact head daba2fbbdb80da47e939d3e3d76fc76b7f195c97.

  • Product CI 44540262462 and Branch Sync 44540262471 succeed.
  • Commit 44540262543 and Copilot / Verification succeed.
  • PR review 44540274743 and Copilot / Review succeed. The complete exact-head aggregate reports zero open, reopened, dismissed, verification-required and unknown findings.
  • The separate approval observer reports unsafe-rules for the existing unprotected develop configuration. That prerequisite and the maintainer's ordinary-merge exception are recorded in upstream #968.

The earlier pending-status text was stale. The producer had completed successfully before the cancellation request, which returned “Cannot cancel a workflow run that is completed.” This update records its successful result.

The original seed publication is 8962f14, with unchanged companion hash 42a798a2790cfc4e576ea302153f87285f1e531011f5242033969c7059c39fe2 and all five qualified numeric-field cases.

Consumer #37

Producer https://github.com/vypdev/ha-ui/actions/runs/44540262543

@efraespada
efraespada merged commit 442c0c5 into develop Nov 19, 2026
6 of 7 checks passed
@github-project-automation github-project-automation Bot moved this from In Progress to Done in vypdev Nov 19, 2026
@vypbot vypbot added state:verified The change has passed Copilot verification. and removed state:ready The change is ready for human approval or merge. state:awaiting-maintainer The next action requires a maintainer response or approval. labels Nov 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

80% Progress: 80% size: XXL Label to indicate a task of size XXL state:verified The change has passed Copilot verification.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

✨🧑‍💻 - Support numeric keyboard hints for text fields

2 participants