Skip to content

🆘 - Record unsafe rules approval block on an unprotected consumer develop branch #968

Open

Description

@efraespada

Have you checked for existing help or discussions?

  • I have searched existing issues and discussions.

What area do you need help with?

Workflow or CI/CD

Describe your problem or question

Record the approval-observer incident on consumer vypdev/ha-ui#37.

At head d6cbc8e528d538ba06670721a9ebe61a8adfc41d, Bugbot completes with complete coverage and zero findings in every active state. Copilot / Review succeeds. The separate Copilot / Approval check fails with unsafe-rules and the summary “Effective branch rules must be readable and dismiss stale approvals.”

The consumer's existing develop branch has no effective rules. The authenticated REST branch-rules endpoint succeeds with [], and classic branch protection returns HTTP 404 “Branch not protected.” This is an observed approval-policy prerequisite. Product verification continues independently.

The maintainer has explicitly authorized ordinary contributor merges after successful product CI, Branch Sync and review, while recording Copilot-only blockers upstream. We will retain the observer's failed result and use the ordinary GitHub merge route after those checks succeed for the final head. The consumer's branch-rule configuration and the observer's approval result remain as observed.

Please document the intended maintainer workflow for this existing consumer configuration so the distinction between a completed review and an unavailable automatic approval is clear.

Steps or attempts you've already made

Environment or context

Consumer ha-ui #36 and PR #37 provide an additive numeric keyboard hint for Domus #91. All workflows run in the self-hosted vypdev group, except the documented npm OIDC publication job. The current follow-up head is a6a459f0d6414216e8346f93fd2d399a878c9f17; its CI and review are running and its Branch Sync succeeds.

Additional context or screenshots

This report records the approval prerequisite. The local package, SSR and browser acceptance results remain independent evidence for the feature. Final merge evidence will identify the exact successful product CI and review head.

Activity

  1. added
    questionFurther information is requested
    priority: mediumImportant but not urgent, should be addressed soon.
    helpLabel to detect help request issues
    on Nov 19, 2026
  2. added theissue type on Nov 19, 2026
  3. moved this to Todo in vypdevon Nov 19, 2026
  4. changed the title [-]Record unsafe-rules approval block on an unprotected consumer develop branch[/-] [+]🆘 - Record unsafe rules approval block on an unprotected consumer develop branch[/+] on Nov 19, 2026
  5. vypbot commented on Nov 19, 2026

    @vypbot
    Contributor

    Hi! I’m @vypbot, the Copilot assistant for this repository.

    I can answer questions, explain the codebase, propose implementation and test plans, review issues and pull requests for potential bugs or security problems, and help authorized maintainers apply changes.

    Try /copilot help to see the available commands, or mention @vypbot with your question.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

helpLabel to detect help request issuespriority: mediumImportant but not urgent, should be addressed soon.questionFurther information is requested

Type

Projects

  • Status
    Todo

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions