Skip to content

chore: Define and test the trusted ref policy for credential health workflow dispatch (#979) - #991

Open
efraespada wants to merge 1 commit into
developfrom
chore/979-define-and-test-the-trusted-ref-policy-for-credential-health-workflow-dispatch
Open

efraespada wants to merge 1 commit into
developfrom
chore/979-define-and-test-the-trusted-ref-policy-for-credential-health-workflow-dispatch

Conversation

@efraespada

@efraespada efraespada commented Nov 19, 2026 •

Copy link
Copy Markdown
Member

This proposes a source-only credential-health operating policy: explicit opt-in, the exact default-ref workflow/repository, current administrator actor IDs plus approved rerun actors, and group vypdev with self-hosted/codex/Linux. Consumer templates, credential transport, endpoints and token scopes are unchanged.

Maintainer policy approval is still required. The selector and validator are editable by workflow collaborators; the causal counter-control removes the condition successfully. They do not establish independent protection against workflow editors. The proposal explicitly treats that privilege as credential authority unless separately verified external controls constrain it. Organization runner-group policy evidence remains unavailable (403); no protection, organization setting, Secret or grant is changed.

The authenticated baseline records both current source and default snapshots: develop self-hosted workflow a3706073…, but master@ace49e4… still has the old hosted workflow 5f093b2c…. It records the two actual admin actors, health token permissions, absent health environment, effective CI rule/classic-protection distinction, and unavailable provider grant/isolation evidence. No default installation or hardened-dispatch claim is made.

Validation: 503 focused tests covering 11 new selector/mutability cases, the existing 82 fake-curl cases, 58 trusted-reader cases and 352 workflow cases; all 36 workflows, typecheck, lint, docs/spec validation and Graphify pass. The installed hook passed build, 944 Jest suites / 18,706 tests / 35 existing skips and lint. Intermediate group-shape failure and passing controls remain recorded; bundles are unchanged.

Review decision: approve this exact actor/default-ref policy and trusted-editor assumption, or request an externally enforced design. The SDD/catalog and operational docs accompany the proposal. No real health dispatch, credential value, qualification model call or evaluated-PR write occurs. Production verification remains disabled.

Refs #979. Do not close the required maintainer policy decision merely because checks pass.

…h-workflow-dispatch: propose and test source credential-health trust policy (#979)
@docs-page

docs-page Bot commented Nov 19, 2026

Copy link
Copy Markdown

To preview the documentation for this pull request, visit the following URL:

docs.page/vypdev/copilot~991

Documentation is deployed and generated using docs.page

@vypbot vypbot changed the title Review source credential-health actor and trusted-ref policy (#979) chore: Define and test the trusted ref policy for credential health workflow dispatch (#979) Nov 19, 2026
@vypbot
vypbot self-requested a review November 19, 2026 20:08
@vypbot vypbot added this to vypdev Nov 19, 2026
@vypbot vypbot moved this to In Progress in vypdev Nov 19, 2026
@vypbot
vypbot changed the base branch from develop to master November 19, 2026 20:08
@vypbot
vypbot changed the base branch from master to develop November 19, 2026 20:08
@vypbot vypbot added the size: XL Indicates that the issue or task is extra large in scope and complexity. label Nov 19, 2026
@vypbot

vypbot commented Nov 19, 2026

Copy link
Copy Markdown
Contributor

Bugbot: review complete

Current status: No active findings on f0655e7.

Pull request · Verified commit · Current review checks · Workflow run

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.66%. Comparing base (239a04f) to head (f0655e7).
⚠️ Report is 291 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #991      +/-   ##
===========================================
+ Coverage    95.25%   95.66%   +0.41%     
===========================================
  Files         1172     1563     +391     
  Lines        39236    49137    +9901     
  Branches     11685    15352    +3667     
===========================================
+ Hits         37373    47006    +9633     
- Misses         698      794      +96     
- Partials      1165     1337     +172     

see 322 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

65% Progress: 65% size: XL Indicates that the issue or task is extra large in scope and complexity. state:awaiting-maintainer state:ready

Projects

Status: In Progress

Development

Successfully merging this pull request may close these issues.

🔧🧑‍💻 - Define and test the trusted ref policy for credential health workflow dispatch

3 participants