Repository navigation
chore: Define and test the trusted ref policy for credential health workflow dispatch (#979) - #991
Open
efraespada wants to merge 1 commit into
Conversation
…h-workflow-dispatch: propose and test source credential-health trust policy (#979)
|
To preview the documentation for this pull request, visit the following URL:
|
vypbot
self-requested a review
November 19, 2026 20:08
1 of 5 tasks
Contributor
Bugbot: review complete
Pull request · Verified commit · Current review checks · Workflow run |
1 of 9 tasks
1 of 5 tasks
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #991 +/- ##
===========================================
+ Coverage 95.25% 95.66% +0.41%
===========================================
Files 1172 1563 +391
Lines 39236 49137 +9901
Branches 11685 15352 +3667
===========================================
+ Hits 37373 47006 +9633
- Misses 698 794 +96
- Partials 1165 1337 +172 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This proposes a source-only credential-health operating policy: explicit opt-in, the exact default-ref workflow/repository, current administrator actor IDs plus approved rerun actors, and group vypdev with self-hosted/codex/Linux. Consumer templates, credential transport, endpoints and token scopes are unchanged.
Maintainer policy approval is still required. The selector and validator are editable by workflow collaborators; the causal counter-control removes the condition successfully. They do not establish independent protection against workflow editors. The proposal explicitly treats that privilege as credential authority unless separately verified external controls constrain it. Organization runner-group policy evidence remains unavailable (403); no protection, organization setting, Secret or grant is changed.
The authenticated baseline records both current source and default snapshots: develop self-hosted workflow a3706073…, but master@ace49e4… still has the old hosted workflow 5f093b2c…. It records the two actual admin actors, health token permissions, absent health environment, effective CI rule/classic-protection distinction, and unavailable provider grant/isolation evidence. No default installation or hardened-dispatch claim is made.
Validation: 503 focused tests covering 11 new selector/mutability cases, the existing 82 fake-curl cases, 58 trusted-reader cases and 352 workflow cases; all 36 workflows, typecheck, lint, docs/spec validation and Graphify pass. The installed hook passed build, 944 Jest suites / 18,706 tests / 35 existing skips and lint. Intermediate group-shape failure and passing controls remain recorded; bundles are unchanged.
Review decision: approve this exact actor/default-ref policy and trusted-editor assumption, or request an externally enforced design. The SDD/catalog and operational docs accompany the proposal. No real health dispatch, credential value, qualification model call or evaluated-PR write occurs. Production verification remains disabled.
Refs #979. Do not close the required maintainer policy decision merely because checks pass.