Skip to content

fix: Forward explicit cancellation into the normal flow Bugbot shadow review operation (#972) - #988

Open
efraespada wants to merge 4 commits into
developfrom
bugfix/972-forward-explicit-cancellation-into-the-normal-flow-bugbot-shadow-review-operation
Open

efraespada wants to merge 4 commits into
developfrom
bugfix/972-forward-explicit-cancellation-into-the-normal-flow-bugbot-shadow-review-operation

Conversation

@efraespada

@efraespada efraespada commented Nov 19, 2026 •

Copy link
Copy Markdown
Member

Explicit cancellation now reaches the actual Bugbot review operation in the normal-flow shadow runner. An interrupted verifier produces an interrupted terminal ledger and exit 130, preserving the previous verified result and preventing a later matched arm from starting.

Seven deterministic controls exercise the actual runner and operation across detection, preparation and verification. All 147 shadow controls pass. Removing only the operation signal reproduces the original false successful completion; both the negative and initial fixture-failure attempts are retained. The shipping TypeScript loader lets these controls reach the actual operation.

The additional evidence commit encountered an unchanged-suite Jest worker SIGSEGV. Its full log is preserved, the affected five tests passed alone, and the complete required hook retry then passed. No check was skipped.

Validation: build, all 943 Jest suites / 18,695 passing tests / 35 existing skips, lint, documentation/specification validation and Graphify. No model calls or evaluated-PR writes. Historical campaigns remain unchanged and production stays disabled. This does not start or qualify #974/#975.

Closes #972.

…shadow-review-operation: propagate explicit cancellation through shadow review (#972)
…shadow-review-operation: preserve cancellation control attempt logs (#972)
@docs-page

docs-page Bot commented Nov 19, 2026

Copy link
Copy Markdown

To preview the documentation for this pull request, visit the following URL:

docs.page/vypdev/copilot~988

Documentation is deployed and generated using docs.page

@vypbot vypbot changed the title Propagate explicit cancellation through the shadow review runner (#972) fix: Forward explicit cancellation into the normal flow Bugbot shadow review operation (#972) Nov 19, 2026
@vypbot
vypbot self-requested a review November 19, 2026 19:03
@vypbot vypbot added this to vypdev Nov 19, 2026
@vypbot vypbot moved this to In Progress in vypdev Nov 19, 2026
@vypbot
vypbot changed the base branch from develop to master November 19, 2026 19:04
@vypbot
vypbot changed the base branch from master to develop November 19, 2026 19:04

@vypbot vypbot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Current status: All findings originating in this review are resolved.
Last reconciled on e1b7d2d. See aggregate Bugbot status.

🤖 Bugbot review snapshot

Bugbot reported 1 potential problem when commit fa9693a was analyzed. This snapshot is historical; use the status block above for current state. 1 finding is linked to changed code.

Findings

  • low: Documented cancellation test path does not resolve from the repository root — quality/bugbot/evidence/issue-972/README.md:35

@vypbot

vypbot commented Nov 19, 2026 •

Copy link
Copy Markdown
Contributor

Bugbot: review complete

Current status: No active findings on e1b7d2d.

Pull request · Verified commit · Current review checks · Workflow run

…shadow-review-operation: use the root-relative cancellation control path (#972)
…shadow-review-operation: preserve raw control logs with lossless compression (#972)
@vypbot vypbot added state:ai-processing state:awaiting-maintainer state:ready size: XXL Indicates an extremely large task or issue that requires significant time and effort to complete. 70% Progress: 70% and removed state:changes-requested state:awaiting-issue-author state:ai-processing labels Nov 19, 2026
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.66%. Comparing base (239a04f) to head (e1b7d2d).
⚠️ Report is 291 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #988      +/-   ##
===========================================
+ Coverage    95.25%   95.66%   +0.41%     
===========================================
  Files         1172     1563     +391     
  Lines        39236    49137    +9901     
  Branches     11685    15352    +3667     
===========================================
+ Hits         37373    47006    +9633     
- Misses         698      794      +96     
- Partials      1165     1337     +172     

see 321 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

65% Progress: 65% size: XXL Indicates an extremely large task or issue that requires significant time and effort to complete. state:awaiting-maintainer state:ready

Projects

Status: In Progress

Development

Successfully merging this pull request may close these issues.

🐛🧑‍💻 - Forward explicit cancellation into the normal flow Bugbot shadow review operation

3 participants