Repository navigation
fix: Forward explicit cancellation into the normal flow Bugbot shadow review operation (#972) - #988
Conversation
|
To preview the documentation for this pull request, visit the following URL:
|
There was a problem hiding this comment.
Current status: All findings originating in this review are resolved.
Last reconciled one1b7d2d. See aggregate Bugbot status.
🤖 Bugbot review snapshot
Bugbot reported 1 potential problem when commit fa9693a was analyzed. This snapshot is historical; use the status block above for current state. 1 finding is linked to changed code.
Findings
- low: Documented cancellation test path does not resolve from the repository root —
quality/bugbot/evidence/issue-972/README.md:35
Bugbot: review complete
Pull request · Verified commit · Current review checks · Workflow run |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #988 +/- ##
===========================================
+ Coverage 95.25% 95.66% +0.41%
===========================================
Files 1172 1563 +391
Lines 39236 49137 +9901
Branches 11685 15352 +3667
===========================================
+ Hits 37373 47006 +9633
- Misses 698 794 +96
- Partials 1165 1337 +172 🚀 New features to boost your workflow:
|
Explicit cancellation now reaches the actual Bugbot review operation in the normal-flow shadow runner. An interrupted verifier produces an interrupted terminal ledger and exit 130, preserving the previous verified result and preventing a later matched arm from starting.
Seven deterministic controls exercise the actual runner and operation across detection, preparation and verification. All 147 shadow controls pass. Removing only the operation signal reproduces the original false successful completion; both the negative and initial fixture-failure attempts are retained. The shipping TypeScript loader lets these controls reach the actual operation.
The additional evidence commit encountered an unchanged-suite Jest worker SIGSEGV. Its full log is preserved, the affected five tests passed alone, and the complete required hook retry then passed. No check was skipped.
Validation: build, all 943 Jest suites / 18,695 passing tests / 35 existing skips, lint, documentation/specification validation and Graphify. No model calls or evaluated-PR writes. Historical campaigns remain unchanged and production stays disabled. This does not start or qualify #974/#975.
Closes #972.