Skip to content

🐛🧑‍💻 - Forward explicit cancellation into the normal flow Bugbot shadow review operation #972

Description

@efraespada

Is there an existing issue for this?

  • I have searched the existing issues.

Which actions are affected?

Pull Request, Commits

Which platforms are affected?

Linux, macOS

Description

The older normal-flow runner supplies cancellation to provider requests but omits bugbotReviewSignal from projectBugbotReviewOperationContext. An interrupted verifier can be retained as a technical failure while the surrounding dry-run operation is incorrectly completed.

Scope and acceptance criteria

  • Pass the existing review signal through the ordinary operation projection and preserve explicit cancellation across detector, preparation and verification.
  • At least six deterministic cases cover cancellation before detection, during detection, between preparation and verification, during verification, after a technical provider interruption, and an uninterrupted completion. Interrupted work cannot mint a completed result/receipt.
  • Capture the actual interrupted attempt and pending request, with zero GitHub write attempts. Keep historical ledgers intact and require a new driver pin before measured reuse.
  • Preserve unlimited investigation time/tokens/turns and optional usage telemetry; do not replace cancellation with automatic research cutoffs.

Reproducing the issue

Use a controlled provider in the normal-flow runner, abort during shadow verification, and inspect the operation result. Reproduce without model or GitHub access.

Pinned source references:

copilot Version

Unreleased develop at ccefb27627cd627ccdb7d5666fd174c2ac1da07b (PR #951); this is not a released or activated profile.

Additional context and comments

Priority and dependencies

Documentation and implementation boundary

Documentation: docs/development/testing.mdx.
Keep Clean Architecture and current coverage/contract gates. When a later implementation changes a public contract, update its catalogued SDD, tests and docs together and validate specifications; update Graphify after code changes.
Read the effective #950 contract in the owning SDD and its current reconciliation amendments; historical pilot deadlines are not current investigation limits.

Fixed invariants and planning state

Backlog only: no in-progress, branch creation, model execution, deployment or activation requested by this planning step.
Keep BUGBOT_VERIFICATION_MODE=disabled. Evaluated PRs must have zero write attempts; retain frozen pilots and independent evaluator/oracle evidence.
Token usage is optional telemetry and cannot stop investigation or reject a supported verdict. Elapsed time and turn count do not impose research cutoffs; explicit cancellation and evidence/SHA integrity remain mandatory. Post-run latency qualification criteria remain distinct from session deadlines.

Activity

  1. added
    bugSomething isn't working
    bugfixSomething isn't working
    priority: mediumImportant but not urgent, should be addressed soon.
    on Nov 19, 2026
  2. added theissue type on Nov 19, 2026
  3. moved this to Todo in vypdevon Nov 19, 2026
  4. changed the title [-]Forward explicit cancellation into the normal-flow Bugbot shadow review operation[/-] [+]🐛 - Forward explicit cancellation into the normal flow Bugbot shadow review operation[/+] on Nov 19, 2026
  5. vypbot commented on Nov 19, 2026

    @vypbot
    Contributor

    Hi! I’m @vypbot, the Copilot assistant for this repository.

    I can answer questions, explain the codebase, propose implementation and test plans, review issues and pull requests for potential bugs or security problems, and help authorized maintainers apply changes.

    Try /copilot help to see the available commands, or mention @vypbot with your question.

  6. moved this from Todo to In Progress in vypdevon Nov 19, 2026
  7. added
    branchedIndicates that a branch has been created for this issue.
    on Nov 19, 2026
  8. 2 remaining items

  9. vypbot commented on Nov 19, 2026

    @vypbot
    Contributor

    Implementation plan

    Current status: Ready to start. No action is required from maintainers before implementation.

    1. Confirm the effective contract
      • Trace the normal-flow runner, operation context projection, and cancellation behavior against the owning Bugbot SDD and reconciliation amendments.
      • Keep BUGBOT_VERIFICATION_MODE=disabled and preserve the backlog-only scope.
    2. Propagate cancellation through the operation
      • Pass the existing bugbotReviewSignal through projectBugbotReviewOperationContext and preserve explicit cancellation across detection, preparation, and verification.
      • Ensure interrupted work cannot produce a completed result or receipt, including after a technical provider interruption.
    3. Add deterministic lifecycle coverage
      • Cover cancellation before detection, during detection, between preparation and verification, during verification, after a technical provider interruption, and uninterrupted completion.
      • Assert interrupted attempts retain the actual attempt and pending request, with zero GitHub write attempts.
    4. Preserve evidence and reuse boundaries
      • Keep historical ledgers intact and require a new driver pin before measured reuse.
      • Retain unlimited investigation time, tokens, and turns; usage telemetry remains optional and cannot act as a cutoff.
    5. Update contracts and validate
      • If the public contract changes, update its catalogued SDD, tests, and documentation together; retain current coverage and contract gates.
      • Run specification validation and relevant quality gates, then update Graphify after code changes.

    Acceptance: Deterministic tests prove all six cancellation and completion cases; every interrupted case retains its attempt and pending request, makes zero GitHub write attempts, and cannot mint a completed result or receipt, while uninterrupted completion succeeds and historical ledgers remain intact.

    Need something else? Mention the bot with a question or use /copilot help.

  10. added
    size: XXLIndicates an extremely large task or issue that requires significant time and effort to complete.
    70%Progress: 70%
    on Nov 19, 2026
  11. vypbot commented on Nov 19, 2026

    @vypbot
    Contributor

    Progress · 65% estimated

    Assessed head e1b7d2d2 · 4/8 supported
    0 need implementation · 4 need verification or clarification

    Verification or clarification needed

    • R21 · - [ ] Capture the actual interrupted attempt and pending request, with zero GitHub write attempts. Keep historical ledgers intact and require a new driver pin before measured reuse — Independently confirm attempt capture, zero GitHub writes, intact historical ledgers, and the new-pin reuse boundary. Requirement source · Evidence at assessed head
    • R48 · Keep Clean Architecture and current coverage/contract gates. When a later implementation changes a public contract, update its catalogued SDD, tests and docs together and validate — Verify the complete coverage and contract gates, Clean Architecture, and the required Graphify update. Requirement source · Evidence at assessed head
    • R54 · Keep BUGBOT_VERIFICATION_MODE=disabled. Evaluated PRs must have zero write attempts; retain frozen pilots and independent evaluator/oracle evidence. — Confirm verification remains disabled and frozen pilot and independent evaluator/oracle evidence are retained. Requirement source · Evidence at assessed head
    • R55 · Token usage is optional telemetry and cannot stop investigation or reject a supported verdict. Elapsed time and turn count do not impose research cutoffs; explicit cancellation and — Verify evidence and SHA integrity and separation of post-run latency criteria from session deadlines. Requirement source · Evidence at assessed head

    Issue · Linked pull request · Full assessment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

65%Progress: 65%branchedIndicates that a branch has been created for this issue.bugSomething isn't workingbugfixSomething isn't workingin-progressStart work on an admitted issue.priority: mediumImportant but not urgent, should be addressed soon.size: XXLIndicates an extremely large task or issue that requires significant time and effort to complete.state:workingWork can proceed on the verified branch or without a branch.

Type

Projects

  • Status
    In Progress

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions