Skip to content

fix: Make the workflow validator reject a CI aggregate gate that ignores worker failures (#978) - #987

Open
efraespada wants to merge 1 commit into
developfrom
bugfix/978-make-the-workflow-validator-reject-a-ci-aggregate-gate-that-ignores-worker-failures
Open

efraespada wants to merge 1 commit into
developfrom
bugfix/978-make-the-workflow-validator-reject-a-ci-aggregate-gate-that-ignores-worker-failures

Conversation

@efraespada

@efraespada efraespada commented Nov 19, 2026 •

Copy link
Copy Markdown
Member

The workflow validator now enforces the complete executable predicate for the CI Check aggregate gate, so replacing it with a no-op, partial check, or masked failure is rejected. This protects the guarantee that all three independent workers must succeed.

What changed

  • Pin and validate the aggregate gate’s complete command without executing candidate workflow YAML.
  • Add mutation coverage for no-op, partial, masked-failure, missing-result, and continue-on-error bypasses, plus execution cases for each worker failure.
  • Document the aggregate predicate contract and its fixture coverage.

Validation

  • 360 targeted workflow tests passed, including all-success, each worker failure, missing results, and continue-on-error mutations.
  • All 36 workflows validated.
  • The installed commit hook passed build, 943 Jest suites / 18,703 tests / 35 existing skips, and lint.
  • Documentation, diff checks, and Graphify passed.

Closes #978

…t-ignores-worker-failures: enforce the CI aggregate success predicate (#978)
@docs-page

docs-page Bot commented Nov 19, 2026

Copy link
Copy Markdown

To preview the documentation for this pull request, visit the following URL:

docs.page/vypdev/copilot~987

Documentation is deployed and generated using docs.page

@vypbot vypbot changed the title Enforce the CI aggregate predicate in the validator (#978) fix: Make the workflow validator reject a CI aggregate gate that ignores worker failures (#978) Nov 19, 2026
@vypbot
vypbot self-requested a review November 19, 2026 18:56
@vypbot vypbot added this to vypdev Nov 19, 2026
@vypbot vypbot moved this to In Progress in vypdev Nov 19, 2026
@vypbot
vypbot changed the base branch from develop to master November 19, 2026 18:57
@vypbot
vypbot changed the base branch from master to develop November 19, 2026 18:57
@vypbot

vypbot commented Nov 19, 2026

Copy link
Copy Markdown
Contributor

Bugbot: review complete

Current status: No active findings on 0b99506.

Pull request · Verified commit · Current review checks · Workflow run

@vypbot

vypbot commented Nov 19, 2026

Copy link
Copy Markdown
Contributor

Copilot approval · Approval blocked

Status: Check CI Check did not succeed.
Completed: 0/4 observed checks succeeded; Bugbot complete.
Action required: Fix the named prerequisite and rerun the observer.
Impact: No new approval is confirmed for this revision.
See checks

Technical evidence

Revision: 0b99506bf04b; base: ccefb27627cd; reason: check-failed.

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.66%. Comparing base (239a04f) to head (0b99506).
⚠️ Report is 291 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #987      +/-   ##
===========================================
+ Coverage    95.25%   95.66%   +0.41%     
===========================================
  Files         1172     1563     +391     
  Lines        39236    49137    +9901     
  Branches     11685    15352    +3667     
===========================================
+ Hits         37373    47006    +9633     
- Misses         698      794      +96     
- Partials      1165     1337     +172     

see 321 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

65% Progress: 65% size: S Small-sized task or issue with minimal effort required. state:awaiting-maintainer state:ready

Projects

Status: In Progress

Development

Successfully merging this pull request may close these issues.

🐛🧑‍💻 - Make the workflow validator reject a CI aggregate gate that ignores worker failures

3 participants