Repository navigation
Description
Is there an existing issue for this?
- I have searched the existing issues.
Which actions are affected?
Pull Request, Commits
Which platforms are affected?
Linux, macOS
Description
The shipped CI gate correctly fails when any worker fails, but assertSourceCiJobs only requires a string command and the three environment bindings. A future replacement with true can pass the workflow validator without enforcing job results.
Scope and acceptance criteria
- Protect the aggregate success predicate through a reusable executable contract, without adding a second CI gate or silently accepting a no-op command.
- At least six fixtures cover all-success, each of the three worker failures, a no-op predicate and a missing result/continue-on-error bypass.
- Run validate:workflows and targeted validator tests. Preserve the existing self-hosted jobs, fork exclusion, public required check name, independent parallel workers and installation templates.
Reproducing the issue
In a YAML fixture, replace the ci-check command with true while preserving needs, always() and STATIC_RESULT/BUILD_RESULT/COVERAGE_RESULT. Verify the current validator accepts it; retain the positive current-gate control.
Pinned source references:
copilot Version
Unreleased develop at ccefb27627cd627ccdb7d5666fd174c2ac1da07b (PR #951); this is not a released or activated profile.
Additional context and comments
Priority and dependencies
- Priority: low. Stage: Independent hardening.
- Blocked by: None; may be prepared independently.
- Follow-up to β¨π§βπ» - Verify Bugbot findings against repository evidence before publicationΒ #950 and merged PR feat: Verify Bugbot findings against repository evidence before publication (#950)Β #951, not a request to reopen or extend that delivery.
- Final closure and observed limitations. Review thread.
Documentation and implementation boundary
Documentation: docs/development/testing.mdx.
Keep Clean Architecture and current coverage/contract gates. When a later implementation changes a public contract, update its catalogued SDD, tests and docs together and validate specifications; update Graphify after code changes.
Read the effective #950 contract in the owning SDD and its current reconciliation amendments; historical pilot deadlines are not current investigation limits.
Fixed invariants and planning state
Backlog only: no in-progress, branch creation, model execution, deployment or activation requested by this planning step.
Keep BUGBOT_VERIFICATION_MODE=disabled. Evaluated PRs must have zero write attempts; retain frozen pilots and independent evaluator/oracle evidence.
Token usage is optional telemetry and cannot stop investigation or reject a supported verdict. Elapsed time and turn count do not impose research cutoffs; explicit cancellation and evidence/SHA integrity remain mandatory. Post-run latency qualification criteria remain distinct from session deadlines.
Metadata
Metadata
Assignees
Labels
Type
Projects
- StatusShow more project fieldsIn Progress
Activity
[-]Make the workflow validator reject a CI aggregate gate that ignores worker failures[/-][+]π - Make the workflow validator reject a CI aggregate gate that ignores worker failures[/+]vypbot commentedon Nov 19, 2026
Hi! Iβm @vypbot, the Copilot assistant for this repository.
I can answer questions, explain the codebase, propose implementation and test plans, review issues and pull requests for potential bugs or security problems, and help authorized maintainers apply changes.
Try
/copilot helpto see the available commands, or mention @vypbot with your question.[-]π - Make the workflow validator reject a CI aggregate gate that ignores worker failures[/-][+]ππ§βπ» - Make the workflow validator reject a CI aggregate gate that ignores worker failures[/+]vypbot commentedon Nov 19, 2026
Implementation plan
Acceptance: The positive current-gate fixture and all-success case pass; each worker-failure, no-op, and missing-result or continue-on-error bypass fixture is rejected; validate:workflows and targeted validator tests pass.
Need something else? Mention the bot with a question or use
/copilot help.bugfix-978-make-the-workflow-validator-reject-a-ci-aggregate-gate-thaβ¦
vypbot commentedon Nov 19, 2026
Progress Β· 65% estimated
Assessed head
0b99506bΒ· 2/5 supported1 need implementation Β· 2 need verification or clarification
Implementation still needed
Verification or clarification needed
Issue Β· Linked pull request Β· Full assessment