Skip to content

fix: Keep deletion only diff hunks out of changed line citation provenance (#973) - #986

Open
efraespada wants to merge 2 commits into
developfrom
bugfix/973-keep-deletion-only-diff-hunks-out-of-changed-line-citation-provenance
Open

efraespada wants to merge 2 commits into
developfrom
bugfix/973-keep-deletion-only-diff-hunks-out-of-changed-line-citation-provenance

Conversation

@efraespada

@efraespada efraespada commented Nov 19, 2026 •

Copy link
Copy Markdown
Member

Deletion-only diff hunks no longer mark adjacent unchanged head citations as changed, improving citation metadata accuracy while preserving deletion anchors and receipt validation.

What changed

  • Changed-line overlap now ignores empty new-side intervals in the broker and its CLI and GitHub Action bundles.
  • Added six real Git and broker regression scenarios for deletion, addition, replacement, boundary, and LEFT citation behavior.
  • Documented the corrected metadata behavior and regression coverage; historical pilot evidence remains unchanged.

Validation

  • Author-provided evidence reports all 146 shadow controls passing.
  • Author-provided evidence reports build and generated-bundle inspection, the full installed hook, documentation and specification checks, and Graphify.

Closes #973

…-provenance: exclude empty new-side citation intervals (#973)
@docs-page

docs-page Bot commented Nov 19, 2026

Copy link
Copy Markdown

To preview the documentation for this pull request, visit the following URL:

docs.page/vypdev/copilot~986

Documentation is deployed and generated using docs.page

@vypbot vypbot changed the title Fix deletion-only citation metadata (#973) fix: Keep deletion only diff hunks out of changed line citation provenance (#973) Nov 19, 2026
@vypbot
vypbot self-requested a review November 19, 2026 18:48
@vypbot vypbot added this to vypdev Nov 19, 2026
@vypbot vypbot moved this to In Progress in vypdev Nov 19, 2026
@vypbot
vypbot changed the base branch from develop to master November 19, 2026 18:48
@vypbot
vypbot changed the base branch from master to develop November 19, 2026 18:48
@vypbot

vypbot commented Nov 19, 2026 •

Copy link
Copy Markdown
Contributor

Bugbot: review complete

Current status: No active findings on dfe3e4a.

Pull request · Verified commit · Current review checks · Workflow run

Previous implementation assessment · d11f0246

@vypbot

vypbot commented Nov 19, 2026 •

Copy link
Copy Markdown
Contributor

Copilot approval · Human review needed

Status: A protected workflow, policy, or trust-boundary file changed.
Completed: 4/4 observed checks succeeded; Bugbot complete.
Action required: Ask a human reviewer to decide.
Impact: No new approval is confirmed for this revision.
See checks

Technical evidence

Revision: dfe3e4aaa08e; base: ccefb27627cd; reason: protected-path.

@vypbot vypbot added the size: L Indicates a large-sized task or issue that requires significant effort and time. label Nov 19, 2026
@vypbot vypbot added the 70% Progress: 70% label Nov 19, 2026
@codecov-commenter

codecov-commenter commented Nov 19, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.66%. Comparing base (239a04f) to head (dfe3e4a).
⚠️ Report is 291 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #986      +/-   ##
===========================================
+ Coverage    95.25%   95.66%   +0.41%     
===========================================
  Files         1172     1563     +391     
  Lines        39236    49137    +9901     
  Branches     11685    15352    +3667     
===========================================
+ Hits         37373    47006    +9633     
- Misses         698      794      +96     
- Partials      1165     1337     +172     

see 321 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

…-provenance: retain raw reporter bytes with lossless compression (#973)
@vypbot vypbot added state:ai-processing size: XL Indicates that the issue or task is extra large in scope and complexity. 65% Progress: 65% and removed state:ai-processing size: L Indicates a large-sized task or issue that requires significant effort and time. 70% Progress: 70% labels Nov 19, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

65% Progress: 65% size: XL Indicates that the issue or task is extra large in scope and complexity. state:awaiting-maintainer state:ready

Projects

Status: In Progress

Development

Successfully merging this pull request may close these issues.

🐛🧑‍💻 - Keep deletion only diff hunks out of changed line citation provenance

3 participants