Skip to content

🐛🧑‍💻 - Keep deletion only diff hunks out of changed line citation provenance #973

Description

@efraespada

Is there an existing issue for this?

  • I have searched the existing issues.

Which actions are affected?

Pull Request, Commits

Which platforms are affected?

Linux, macOS

Description

broker.cjs represents a zero-count new-side hunk as an inverted interval. A citation spanning adjacent unchanged lines can then be marked inChangedLines=true. SHA/blob/range validation still runs; this issue corrects the change metadata used in evaluation.

Scope and acceptance criteria

  • Derive changed-line overlap only from nonempty new-side intervals while preserving the existing deletion anchor contract and immutable candidate anchor.
  • At least six distinct cases cover a deletion-only hunk, multiple deletion hunks, a true addition, a mixed hunk, unchanged adjacent boundary lines, and a legitimate old-side deletion citation.
  • Use pinned Git fixtures and the real broker/receipt validation. Foreign or undelivered citations remain rejected; metadata correction must not relocate a finding.
  • Document the correction and update the owning SDD/catalog only if the public contract changes. Keep old pilot artifacts unchanged.

Reproducing the issue

Use @@ -3 +2,0 @@ and a new-tree citation spanning lines 1-2. Neither line is added, yet the current overlap predicate accepts the empty interval.

Pinned source references:

copilot Version

Unreleased develop at ccefb27627cd627ccdb7d5666fd174c2ac1da07b (PR #951); this is not a released or activated profile.

Additional context and comments

Priority and dependencies

Documentation and implementation boundary

Documentation: docs/bugbot/quality-observability.mdx.
Keep Clean Architecture and current coverage/contract gates. When a later implementation changes a public contract, update its catalogued SDD, tests and docs together and validate specifications; update Graphify after code changes.
Read the effective #950 contract in the owning SDD and its current reconciliation amendments; historical pilot deadlines are not current investigation limits.

Fixed invariants and planning state

Backlog only: no in-progress, branch creation, model execution, deployment or activation requested by this planning step.
Keep BUGBOT_VERIFICATION_MODE=disabled. Evaluated PRs must have zero write attempts; retain frozen pilots and independent evaluator/oracle evidence.
Token usage is optional telemetry and cannot stop investigation or reject a supported verdict. Elapsed time and turn count do not impose research cutoffs; explicit cancellation and evidence/SHA integrity remain mandatory. Post-run latency qualification criteria remain distinct from session deadlines.

Activity

  1. added
    bugSomething isn't working
    bugfixSomething isn't working
    priority: mediumImportant but not urgent, should be addressed soon.
    on Nov 19, 2026
  2. added theissue type on Nov 19, 2026
  3. moved this to Todo in vypdevon Nov 19, 2026
  4. changed the title [-]Keep deletion-only diff hunks out of changed-line citation provenance[/-] [+]🐛 - Keep deletion only diff hunks out of changed line citation provenance[/+] on Nov 19, 2026
  5. vypbot commented on Nov 19, 2026

    @vypbot
    Contributor

    Hi! I’m @vypbot, the Copilot assistant for this repository.

    I can answer questions, explain the codebase, propose implementation and test plans, review issues and pull requests for potential bugs or security problems, and help authorized maintainers apply changes.

    Try /copilot help to see the available commands, or mention @vypbot with your question.

  6. moved this from Todo to In Progress in vypdevon Nov 19, 2026
  7. added
    branchedIndicates that a branch has been created for this issue.
    on Nov 19, 2026
  8. 5 remaining items

  9. added
    size: LIndicates a large-sized task or issue that requires significant effort and time.
    70%Progress: 70%
    and removed on Nov 19, 2026
  10. vypbot commented on Nov 19, 2026

    @vypbot
    Contributor

    Progress · 65% estimated

    Assessed head dfe3e4aa · 3/6 supported
    0 need implementation · 3 need verification or clarification

    Verification or clarification needed

    • R21 · - [ ] Use pinned Git fixtures and the real broker/receipt validation. Foreign or undelivered citations remain rejected; metadata correction must not relocate a finding. — Undelivered-citation coverage and test execution are not independently verified. Requirement source · Evidence at assessed head
    • R48 · Keep Clean Architecture and current coverage/contract gates. When a later implementation changes a public contract, update its catalogued SDD, tests and docs together and validate — Coverage and contract gates, specification validation, and Graphify completion are unverified. Requirement source · Evidence at assessed head
    • R54 · Keep BUGBOT_VERIFICATION_MODE=disabled. Evaluated PRs must have zero write attempts; retain frozen pilots and independent evaluator/oracle evidence. — Zero-write behavior and retained independent evaluator/oracle evidence lack independent verification. Requirement source · Evidence at assessed head

    Issue · Linked pull request · Full assessment

  11. added
    size: XLIndicates that the issue or task is extra large in scope and complexity.
    65%Progress: 65%
    and removed
    size: LIndicates a large-sized task or issue that requires significant effort and time.
    70%Progress: 70%
    state:workingWork can proceed on the verified branch or without a branch.
    on Nov 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

65%Progress: 65%branchedIndicates that a branch has been created for this issue.bugSomething isn't workingbugfixSomething isn't workingin-progressStart work on an admitted issue.priority: mediumImportant but not urgent, should be addressed soon.size: XLIndicates that the issue or task is extra large in scope and complexity.state:awaiting-maintainerstate:blocked

Type

Projects

  • Status
    In Progress

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions