Repository navigation
refactor(session): move instance read side to session/instancestore (I2) - #1714
Merged
Merged
Conversation
I2 of project_plans/package-split-ocp/instance-dto-lowering-plan.md. Get/List*/*WithOptions, applyLoadOptions, the session-artifacts getters and the ent-to-InstanceData mapper become methods of instancestore.Instances, embedded in EntRepository and built in initStores (every constructor path). Method bodies are unchanged apart from the receiver; callers are untouched through promotion. Adds the isolate_instancestore depguard row, boundaries/budget rows and go_sources wiring.
Contributor
|
Selective e2e (shadow, non-blocking): 0 of 0 targets selected; shard jobs: skipped. The full suite in build.yml stays authoritative. |
Adds tests for the GetAllSessionArtifacts non-empty filter, the (nil, nil) artifacts path, the exact not-found text and every scalar mapper field (all mutation-checked). Renames the loop variable that shadowed the receiver, orders the legacy_pr_readers row, and ratchets the session budget row to the measured values. scoping-budget-raise: session imports 67 -> 68 (the new session/instancestore import; loc 25556 -> 25126, files unchanged)
Contributor
|
Selective e2e (shadow, non-blocking): 0 of 0 targets selected; shard jobs: skipped. The full suite in build.yml stays authoritative. |
Contributor
CI memory (Go affected-package tests)2 benchmarks (no base to compare with)
|
| Benchmark | Value | Range |
|---|---|---|
peak_used [max] |
5763 MB |
— |
min_available [min] |
10218 MB |
— |
Environment
| Head | |
|---|---|
sha |
dc7942182a59fc23dc933979ff41f2702c19968b |
Head-only report: add a base to see changes.
Contributor
📊 Feature E2E CoverageFeature E2E coverage: 57/351 tested (16%)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I2 of
project_plans/package-split-ocp/instance-dto-lowering-plan.md. Moves the instance read side (Get/List*/*WithOptions,applyLoadOptions, session-artifact getters,GetClaudeConversationUUIDBySessionUUID, the ent-to-InstanceDatamapper; about 450 lines) out ofsession/ent_repository.gointo the new leafsession/instancestore.EntRepositoryembeds*instancestore.Instances, built ininitStores(), so callers are unchanged through promotion. No consumer-side port is needed: the read side takes only the ent client.Verified:
rtoi).storage_test.goandent_repository_test.gounchanged;TestEntRepository_should_BuildEveryEmbeddedStore_When_ConstructedByAnyPathpasses.applyLoadOptionsfilter dropped and forced-on, project edge, claude metadata, list preset, empty-id guard, by-uuid, by-status) all killed.scoping t9/boundaries/inversions/budget --base origin/mainclean.make gazelleno diff.go test ./session/...passes exceptsession/unfinishedandsession/unfinished/gogitstorefsnotify-timing tests (code untouched here; not re-run on main).