Skip to content

refactor(session): move single-column updaters into instancestore (I3) - #1715

Merged
tstapler merged 2 commits into
mainfrom
refactor/i3-instancestore-updaters
Nov 20, 2026
Merged

tstapler merged 2 commits into
mainfrom
refactor/i3-instancestore-updaters

Conversation

@tstapler

Copy link
Copy Markdown
Owner

Step I3 of project_plans/package-split-ocp/instance-dto-lowering-plan.md: 11 single-column updaters, artifacts writer, UpdateSessionMetadata and UpdateGitHubPR* (243 lines) move from session/ent_repository.go to session/instancestore/updaters.go. Only the receiver and Client -> client change; EntRepository keeps its method set via the embedded store from #1714 (no new embedded-store wiring needed, so the reflect test is unaffected).

  • Tests: new session/instancestore/updaters_test.go; all 20 per-column set/clear mutations were killed. go test ./session ./session/instancestore pass; ./server/services fails only the known fsnotify TestClaudeSettingsWatcher_*.
  • Budget: session 25126 -> 24875 loc; instancestore 5/475 -> 6/736 (raise carried by the scoping-budget-raise: commit line). scoping t9/boundaries/inversions pass.
  • Plan marks I3 DONE.

…into instancestore (I3)

Moves UpdateGitHubPR*, UpdateSessionArtifacts, the review-queue/timestamp
single-column updaters and UpdateSessionMetadata onto instancestore.Instances;
EntRepository keeps the method set via the embedded store.

scoping-budget-raise: session/instancestore receives the ~243 lines removed from session (session 25126 -> 24875 loc)
@github-actions

Copy link
Copy Markdown
Contributor

Selective e2e (shadow, non-blocking): 0 of 0 targets selected; shard jobs: skipped. The full suite in build.yml stays authoritative.

@github-actions

github-actions Bot commented Nov 20, 2026 •

Copy link
Copy Markdown
Contributor

CI memory (Go affected-package tests)

2 benchmarks (no base to compare with)

ci-memory/test-affected

Benchmark Value Range
peak_used [max] 4254 MB —
min_available [min] 11728 MB —
Environment
Head
sha 915a0d17e551f864df659aae9441b4e0bec258ea

Head-only report: add a base to see changes.

@github-actions

Copy link
Copy Markdown
Contributor

📊 Feature E2E Coverage

Feature E2E coverage: 57/351 tested (16%)

Run make e2e-report locally to view the full Allure report.

…review fixes for I3

Extends the updater tests so Where(title) and SetUpdatedAt mutants are killed
(39/39 mutants), and fixes comments that still cited ent_repository.go.

scoping-budget-raise: session/instancestore gains the lines removed from session (session 25126 -> 24875 loc, a 251 drop; instancestore 475 -> 737)
@github-actions

Copy link
Copy Markdown
Contributor

Selective e2e (shadow, non-blocking): 0 of 0 targets selected; shard jobs: skipped. The full suite in build.yml stays authoritative.

@tstapler
tstapler merged commit e91fc01 into main Nov 20, 2026
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant