Repository navigation
refactor(session): move single-column updaters into instancestore (I3) - #1715
Merged
Merged
Conversation
…into instancestore (I3) Moves UpdateGitHubPR*, UpdateSessionArtifacts, the review-queue/timestamp single-column updaters and UpdateSessionMetadata onto instancestore.Instances; EntRepository keeps the method set via the embedded store. scoping-budget-raise: session/instancestore receives the ~243 lines removed from session (session 25126 -> 24875 loc)
Contributor
|
Selective e2e (shadow, non-blocking): 0 of 0 targets selected; shard jobs: skipped. The full suite in build.yml stays authoritative. |
Contributor
CI memory (Go affected-package tests)2 benchmarks (no base to compare with)
|
| Benchmark | Value | Range |
|---|---|---|
peak_used [max] |
4254 MB |
— |
min_available [min] |
11728 MB |
— |
Environment
| Head | |
|---|---|
sha |
915a0d17e551f864df659aae9441b4e0bec258ea |
Head-only report: add a base to see changes.
Contributor
📊 Feature E2E CoverageFeature E2E coverage: 57/351 tested (16%)
|
…review fixes for I3 Extends the updater tests so Where(title) and SetUpdatedAt mutants are killed (39/39 mutants), and fixes comments that still cited ent_repository.go. scoping-budget-raise: session/instancestore gains the lines removed from session (session 25126 -> 24875 loc, a 251 drop; instancestore 475 -> 737)
Contributor
|
Selective e2e (shadow, non-blocking): 0 of 0 targets selected; shard jobs: skipped. The full suite in build.yml stays authoritative. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Step I3 of
project_plans/package-split-ocp/instance-dto-lowering-plan.md: 11 single-column updaters, artifacts writer,UpdateSessionMetadataandUpdateGitHubPR*(243 lines) move fromsession/ent_repository.gotosession/instancestore/updaters.go. Only the receiver andClient->clientchange;EntRepositorykeeps its method set via the embedded store from #1714 (no new embedded-store wiring needed, so the reflect test is unaffected).session/instancestore/updaters_test.go; all 20 per-column set/clear mutations were killed.go test ./session ./session/instancestorepass;./server/servicesfails only the known fsnotifyTestClaudeSettingsWatcher_*.scoping-budget-raise:commit line).scoping t9/boundaries/inversionspass.