Skip to content

Deprecate BatchOperationResetActivities.reset_attempts #878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ks-temporal wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Deprecate BatchOperationResetActivities.reset_attempts #878

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
057923e
Deprecate BatchOperationResetActivities.reset_attempts
ks-temporal Oct 2, 2026
e22d802
Regerenate api files
ks-temporal Oct 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion openapi/openapiv2.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14545,7 +14545,7 @@
},
"resetAttempts": {
"type": "boolean",
"description": "Setting this flag will also reset the number of attempts."
"description": "Deprecated. Not supported: a reset always resets the number of attempts, and\ntemporal.api.workflowservice.v1.ResetActivityRequest has no equivalent field to carry this\none, so it is ignored."
},
"resetHeartbeat": {
"type": "boolean",
Expand Down
5 changes: 4 additions & 1 deletion openapi/openapiv3.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10565,7 +10565,10 @@ components:
type: boolean
resetAttempts:
type: boolean
description: Setting this flag will also reset the number of attempts.
description: |-
Deprecated. Not supported: a reset always resets the number of attempts, and
temporal.api.workflowservice.v1.ResetActivityRequest has no equivalent field to carry this
one, so it is ignored.
resetHeartbeat:
type: boolean
description: Setting this flag will also reset the heartbeat details.
Expand Down
6 changes: 4 additions & 2 deletions temporal/api/batch/v1/message.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,8 +176,10 @@ message BatchOperationResetActivities {
bool match_all = 3;
}

// Setting this flag will also reset the number of attempts.
bool reset_attempts = 4;
// Deprecated. Not supported: a reset always resets the number of attempts, and
// temporal.api.workflowservice.v1.ResetActivityRequest has no equivalent field to carry this
// one, so it is ignored.
bool reset_attempts = 4 [deprecated = true];

// Setting this flag will also reset the heartbeat details.
bool reset_heartbeat = 5;
Expand Down
Loading