Repository navigation
Deprecate BatchOperationResetActivities.reset_attempts - #878
Open
ks-temporal wants to merge 2 commits into
Open
ks-temporal wants to merge 2 commits into
ks-temporal wants to merge 2 commits into
Conversation
The ResetActivityRequest has no equivalent field, and the server always resets the attempt count. A false value has no effect.
4 of 5 tasks
fretz12
approved these changes
Oct 2, 2026
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The changes consistently document the unsupported flag without changing its field number, type, or runtime behavior.
Review effort: Balanced
Findings: None
What changed in this PR
Deprecates the unsupported BatchOperationResetActivities.reset_attempts field while preserving compatibility.
Changes:
- Adds the protobuf deprecation marker and explains why the flag is ignored.
- Updates both OpenAPI descriptions to match.
| File | Description |
|---|---|
| temporal/api/batch/v1/message.proto | Deprecates and documents the unsupported field. |
| openapi/openapiv3.yaml | Updates the field description. |
| openapi/openapiv2.json | Updates the field description. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Marked
BatchOperationResetActivities.reset_attemptsas deprecated, documenting that it isnot supported.
Why?
The field cannot be honored:
temporal.api.workflowservice.v1.ResetActivityRequest, which this message mirrors (see theNOTE above the message), has no equivalent field, so there is nothing to carry the flag to the
server.
falsevalue has no effect.ResetActivityExecutionRequest, the newer reset API, already reserves the name rather thandefining it.
Breaking changes
None.