Skip to content

test: re-enable FFM sample coverage - #917

Closed
Hokila wants to merge 1 commit into
swiftlang:mainfrom
Hokila:codex/ffm-test-maintenance
Closed

Hokila wants to merge 1 commit into
swiftlang:mainfrom
Hokila:codex/ffm-test-maintenance

Conversation

@Hokila

@Hokila Hokila commented Sep 16, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Re-enable the FFM Runnable upcall integration test in both sample apps.
  • Update the JAR FFM sample to use java.lang.Runnable with run().
  • Re-enable the FFM instance-property test for getX().
  • Correct three UnaryOperator tests that accidentally called the corresponding BinaryOperator methods.

Testing

./gradlew -PswiftJavaJdk=23 :Samples:SwiftJavaExtractFFMSampleApp:test :Samples:SwiftAndJavaJarFFMSampleLib:test --no-daemon

The relevant test suites pass with zero failures, errors, or skipped tests.

Question for maintainers

These changes are related FFM sample-test maintenance across two sample applications. Would you prefer this to remain as one PR, or should it be split into separate PRs per sample/application?

@Hokila
Hokila requested a review from ktoso as a code owner September 16, 2026 07:49
@ktoso

ktoso commented Sep 16, 2026

Copy link
Copy Markdown
Collaborator

Thanks for the contribution, a single PR is good, the sample apps serve as "end to end tests" really, so it is good to update them along with fixes

@Hokila Hokila closed this Sep 16, 2026
@Hokila
Hokila deleted the codex/ffm-test-maintenance branch September 16, 2026 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants