Skip to content

test: re-enable FFM sample coverage - #918

Merged
ktoso merged 1 commit into
swiftlang:mainfrom
Hokila:ffm-test-maintenance
Sep 16, 2026
Merged

ktoso merged 1 commit into
swiftlang:mainfrom
Hokila:ffm-test-maintenance

Conversation

@Hokila

@Hokila Hokila commented Sep 16, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Re-enable the FFM Runnable upcall integration test in both sample apps.
  • Update the JAR FFM sample to use java.lang.Runnable with run().
  • Re-enable the FFM instance-property test for getX().
  • Correct three UnaryOperator tests that accidentally called the corresponding BinaryOperator methods.

Testing

./gradlew :Samples:SwiftJavaExtractFFMSampleApp:test :Samples:SwiftAndJavaJarFFMSampleLib:test --no-daemon

Tested with JDK 25.0.4.1. Both FFM sample test tasks pass successfully.

Question for maintainers

These changes are related FFM sample-test maintenance across two sample applications. Would you prefer this to remain as one PR, or should it be split into separate PRs per sample/application?

This supersedes #917, which was closed automatically when the source branch was renamed.

@Hokila
Hokila requested a review from ktoso as a code owner September 16, 2026 07:55
@Hokila
Hokila marked this pull request as draft September 16, 2026 08:23
@Hokila
Hokila marked this pull request as ready for review September 16, 2026 08:28
@ktoso

ktoso commented Sep 16, 2026

Copy link
Copy Markdown
Collaborator

Thanks!

@ktoso
ktoso merged commit b834a0d into swiftlang:main Sep 16, 2026
84 checks passed
@Hokila
Hokila deleted the ffm-test-maintenance branch September 16, 2026 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants