Skip to content

Fix broken-pipe panic in update-config-settings #981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
leighmcculloch merged 2 commits into from
Sep 4, 2026
Merged

Fix broken-pipe panic in update-config-settings #981

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
62b8162
avoid broken-pipe panic reading stellar version
leighmcculloch Sep 4, 2026
58172c3
use stellar version --only-version-major flag
leighmcculloch Sep 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .scripts/update-config-settings
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ fi
# stellar-cli's major version tracks the protocol it supports. If testnet has
# advanced beyond it, `stellar network settings` silently omits settings the
# older XDR doesn't know about, so fail loudly to prompt bumping the pinned CLI.
cli_protocol="$(stellar version | head -n1 | sed -E 's/^stellar ([0-9]+).*/\1/')"
cli_protocol="$(stellar version --only-version-major)"
if [ "$protocol" -gt "$cli_protocol" ]; then
echo "error: testnet is on protocol $protocol but stellar-cli supports protocol $cli_protocol; bump the pinned stellar-cli version" >&2
exit 1
Expand Down
Loading