Fix broken-pipe panic in update-config-settings - #981
Merged
Conversation
leighmcculloch
marked this pull request as ready for review
September 4, 2026 15:30
leighmcculloch
enabled auto-merge (squash)
September 4, 2026 15:31
fnando
approved these changes
Sep 4, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Replaces the fragile version-output pipeline with Stellar CLI’s dedicated major-version flag.
Changes:
- Uses
stellar version --only-version-major. - Prevents broken-pipe panics during config updates.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Read the CLI's major version with
stellar version --only-version-majorinstead of pipingstellar version's full output throughhead/sed.Why
The "Update Config Settings" workflow failed CI with a broken-pipe panic when
stellar version | head -n1 | sed ...letheadclose its end of the pipe whilestellarwas still writing later lines: