Repository navigation
fix: describe accepted MCP update syntax in tool schemas - #2651
Merged
Merged
Conversation
erichare
force-pushed
the
fix/mcp-update-wire-schema
branch
from
October 21, 2026 18:51
231ab04 to
0405aa0
Compare
3 of 4 tasks
Contributor
📈 Unit Test Coverage Delta vs Main Branch
|
Contributor
Unit Test Coverage Report
|
Contributor
➡️ Integration Test Coverage Delta vs Main Branch (hcd-it)
|
Contributor
Integration Test Coverage Report (hcd-it)
|
Contributor
➡️ Integration Test Coverage Delta vs Main Branch (dse69-it)
|
Contributor
Integration Test Coverage Report (dse69-it)
|
This was referenced Oct 23, 2026
erichare
commented
Oct 27, 2026
erichare
force-pushed
the
fix/mcp-update-wire-schema
branch
from
November 5, 2026 19:28
bba8237 to
e1c9f67
Compare
This was referenced Nov 5, 2026
This was referenced Nov 5, 2026
amorton
requested changes
Nov 16, 2026
amorton
left a comment
Contributor
There was a problem hiding this comment.
A few changes pls for text and things
…contract test McpSchemaCustomizerTest now covers each rule the customizer adds in four tests: JSON property names, ignored and hidden fields, descriptions, and component references. It reaches every line and branch of the customizer. McpClauseSchemaContractTest keeps the checks that published clause schemas agree with the server's parsers. Tool payload cases that repeat McpSchemaIntegrationTest are removed, the update cases run once against the update clause schema instead of once per tool, and the rerank credentials case is a row in the override table.
This was referenced Nov 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
Describes all thirteen update operators in the shared UpdateClause schema, including
$pullAll, which only tables accept. Each operator description says what it does to Document fields or Table columns, and every operator has an example. The enum and schema use the same wire-name constants. McpClauseSchemaContractTest checks accepted and malformed updates against both the UpdateClause schema and the parser, and checks that all three update tools require an update clause. McpSchemaCustomizerTest covers each rule the schema customizer adds.Which issue(s) this PR fixes:
Fixes #2631.
Verification
99 focused tests passed with 0 failures, 0 errors, and 0 skips at
9485dc0c8, after merging main. JaCoCo shows those tests cover every line and branch of McpSchemaCustomizer. The local format check did not run because this machine only has JDK 25 and google-java-format 1.21 needs JDK 21, so CI runs it. Manual client checks were not run.Checklist
MCP stack
Merges bottom up; row 1 is the bottom of the stack.