Skip to content

feat: describe MCP tool side effects and retry behavior - #2649

Open
erichare wants to merge 4 commits into
fix/mcp-safe-loggingfrom
fix/mcp-tool-behavior-hints
Open

erichare wants to merge 4 commits into
fix/mcp-safe-loggingfrom
fix/mcp-tool-behavior-hints

Conversation

@erichare

@erichare erichare commented Oct 19, 2026 •

Copy link
Copy Markdown
Contributor

What this PR does:

Publishes side-effect and retry hints for all 35 MCP tools. The catalog test checks the values clients get from tools/list, including which tools can call an external provider.

Which issue(s) this PR fixes:

Fixes #2636. Builds on #2648 and is the base for #2655. Full stack.

Verification

36 focused Java tests passed on JDK 25 at 09c9c1473. The catalog is fetched once. Each tool still has its own expected hints. GitHub checks.

./mvnw -o -B -ntp clean test \
  -DskipITs -Dfmt.skip=true -Dxml-format.skip=true -Dsurefire.failIfNoSpecifiedTests=false \
  -Dquarkus.http.test-port=19281 -Dtest=McpToolAnnotationsTest

Checklist

  • Changes manually tested
  • Automated Tests added/updated
  • Documentation added/updated
  • CLA Signed: DataStax CLA

@github-actions

github-actions Bot commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

📈 Unit Test Coverage Delta vs Main Branch

Metric Value
Main Branch 57.12%
This PR 58.04%
Delta 🟢 +0.92%
✅ Coverage improved!

@github-actions

github-actions Bot commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

Unit Test Coverage Report

Overall Project 58.04% 🍏
File Coverage
GeneralCommandTools.java 22.58% 🍏
KeyspaceCommandTools.java 0% 🍏
CollectionCommandTools.java 0% 🍏

@github-actions

github-actions Bot commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

📈 Integration Test Coverage Delta vs Main Branch (dse69-it)

Metric Value
Main Branch 72.75%
This PR 72.84%
Delta 🟢 +0.10%
✅ Coverage improved!

@github-actions

github-actions Bot commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

Integration Test Coverage Report (dse69-it)

Overall Project 72.84% 🍏
File Coverage
KeyspaceCommandTools.java 100% 🍏
CollectionCommandTools.java 100% 🍏
GeneralCommandTools.java 100% 🍏

@github-actions

github-actions Bot commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

📈 Integration Test Coverage Delta vs Main Branch (hcd-it)

Metric Value
Main Branch 74.21%
This PR 74.30%
Delta 🟢 +0.09%
✅ Coverage improved!

@github-actions

github-actions Bot commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

Integration Test Coverage Report (hcd-it)

Overall Project 74.3% 🍏
File Coverage
KeyspaceCommandTools.java 100% 🍏
CollectionCommandTools.java 100% 🍏
GeneralCommandTools.java 100% 🍏

@erichare
erichare added this pull request to stack #2667 October 27, 2026 23:12
@erichare
erichare force-pushed the fix/mcp-tool-behavior-hints branch from 1072454 to f6e2ef4 Compare October 27, 2026 23:54
@erichare
erichare removed this pull request from stack #2667 November 5, 2026 19:26
@erichare
erichare force-pushed the fix/mcp-tool-behavior-hints branch from f6e2ef4 to bd93b02 Compare November 5, 2026 19:28
@erichare erichare changed the title Describe MCP tool side effects and retry behavior feat: describe MCP tool side effects and retry behavior Nov 5, 2026
@erichare
erichare added this pull request to stack #2672 November 5, 2026 19:29
@erichare
erichare force-pushed the fix/mcp-tool-behavior-hints branch from c65ca17 to ba24582 Compare November 19, 2026 05:41

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MCP: Describe tool side effects and retry behavior

1 participant